8000 Remove GPUCommandEncoder.writeTimestamp by beaufortfrancois · Pull Request #4370 · gpuweb/gpuweb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove GPUCommandEncoder.writeTimestamp #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove GPUCommandEncoder.writeTimestamp #4370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 0 additions & 53 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9446,8 +9446,6 @@ interface GPUCommandEncoder {
optional GPUSize64 offset = 0,
optional GPUSize64 size);

undefined writeTimestamp(GPUQuerySet querySet, GPUSize32 queryIndex);

undefined resolveQuerySet(
GPUQuerySet querySet,
GPUSize32 firstQuery,
Expand Down Expand Up @@ -10005,54 +10003,6 @@ dictionary GPUCommandEncoderDescriptor
## Queries ## {#command-encoder-queries}

<dl dfn-type=method dfn-for=GPUCommandEncoder>
: <dfn>writeTimestamp(querySet, queryIndex)</dfn>
::
Writes a timestamp value into a querySet when all previous commands have completed executing.

Note: Timestamp query values are written in nanoseconds, but how the value is determined is
implementation-defined and may not increase monotonically. See [[#timestamp]] for details.

<div algorithm=GPUCommandEncoder.writeTimestamp>
<div data-timeline=content>
**Called on:** {{GPUCommandEncoder}} |this|.

**Arguments:**

<pre class=argumentdef for="GPUCommandEncoder/writeTimestamp(querySet, queryIndex)">
|querySet|: The query set that will store the timestamp values.
|queryIndex|: The index of the query in the query set.
</pre>

**Returns:** {{undefined}}

[=Content timeline=] steps:

1. If {{GPUFeatureName/"timestamp-query"}} is not [=enabled for=] |this|:
1. Throw a {{TypeError}}.
1. Issue the subsequent steps on the [=Device timeline=] of |this|.{{GPUObjectBase/[[device]]}}:
</div>
<div data-timeline=device>
[=Device timeline=] steps:

1. [$Validate the encoder state$] of |this|. If it returns false, stop.
1. If any of the following conditions are unsatisfied, make |this| [=invalid=] and stop.

<div class=validusage>
- |querySet| is [$valid to use with$] |this|.
- |querySet|.{{GPUQuerySet/type}} is {{GPUQueryType/"timestamp"}}.
- |queryIndex| &lt; |querySet|.{{GPUQuerySet/count}}.
</div>

1. [$Enqueue a command$] on |this| which issues the subsequent steps on the
[=Queue timeline=] when executed.
</div>
<div data-timeline=queue>
[=Queue timeline=] steps:

1. Write the [$current queue timestamp$] into |querySet| at index |queryIndex|.
</div>
</div>

: <dfn>resolveQuerySet(querySet, firstQuery, queryCount, destination, destinationOffset)</dfn>
::
Resolves query results from a {{GPUQuerySet}} out into a range of a {{GPUBuffer}}.
Expand Down Expand Up @@ -13130,7 +13080,6 @@ and ended by calling {{GPURenderPassEncoder/beginOcclusionQuery()}} and

Timestamp queries allow applications to write timestamps to a {{GPUQuerySet}}, using:

- {{GPUCommandEncoder}}.{{GPUCommandEncoder/writeTimestamp()}}
- {{GPUComputePassDescriptor}}.{{GPUComputePassDescriptor/timestampWrites}}
- {{GPURenderPassDescriptor}}.{{GPURenderPassDescriptor/timestampWrites}}

Expand Down Expand Up @@ -15324,8 +15273,6 @@ This feature adds the following [=optional API surfaces=]:

- New {{GPUQueryType}} values:
- {{GPUQueryType/"timestamp"}}
- New {{GPUCommandEncoder}} methods:
- {{GPUCommandEncoder/writeTimestamp()}}
- New {{GPUComputePassDescriptor}} members:
- {{GPUComputePassDescriptor/timestampWrites}}
- New {{GPURenderPassDescriptor}} members:
Expand Down
0