8000 Sync upstream Prometheus at 898af61 by charleskorn · Pull Request #840 · grafana/mimir-prometheus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sync upstream Prometheus at 898af61 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 13, 2025
Merged

Conversation

charleskorn
Copy link
Contributor
@charleskorn charleskorn commented Mar 12, 2025

Codelax and others added 20 commits June 6, 2024 09:47
Signed-off-by: Jules Casteran <jcasteran@scaleway.com>
Signed-off-by: Jules Casteran <jcasteran@scaleway.com>
Signed-off-by: Jules Casteran <jcasteran@scaleway.com>
Signed-off-by: Jules Casteran <jcasteran@scaleway.com>
Signed-off-by: Jules Casteran <jcasteran@scaleway.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
… (#16001)

* util/httputil: Benchmark newCompressedResponseWriter

This benchmark illustrates that newCompressedResponseWriter incurs a
prohibitive amount of heap allocations when handling a request containing a
malicious Accept-Encoding header.¬

Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>

* util/httputil: Improve newCompressedResponseWriter

This change dramatically reduces the heap allocations (in bytes)
incurred when handling a request containing a malicious Accept-Encoding header.

Below are some benchmark results; for conciseness, I've omitted the name of the
benchmark function (BenchmarkNewCompressionHandler_MaliciousAcceptEncoding):

```
goos: darwin
goarch: amd64
pkg: github.com/prometheus/prometheus/util/httputil
cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
│     old     │                 new                 │
│   sec/op    │   sec/op     vs base                │
  18.60m ± 2%   13.54m ± 3%  -27.17% (p=0.000 n=10)

│       old        │                 new                 │
│       B/op       │    B/op     vs base                 │
  16785442.50 ± 0%   32.00 ± 0%  -100.00% (p=0.000 n=10)

│    old     │                new                 │
│ allocs/op  │ allocs/op   vs base                │
  2.000 ± 0%   1.000 ± 0%  -50.00% (p=0.000 n=10)
```

Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>

---------

Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>
feat(scaleway-sd): add labels for multiple public IPs
…6013)

Current main is broken due to:

```
Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
```

This is odd given `actions/cache: 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9` has a comment of v4.0.2 (so not v1 and v2), trying 4.1.0.

https://github.com/prometheus/prometheus/actions/runs/13267052807/job/37037025130?pr=16011

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: beorn7 <beorn@grafana.com>
promql: Fix counter reset detection in subqueries with histograms
This should help a bit with the header icon overflow on narrow screens and
also overall make things look less cluttered.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
…nt cache (#16024)

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
…(...) (#16012)

* model/textparse: Change parser interface Metric(...) string to Labels(...)

Simplified the interface given no one is using the return argument.
Renamed for clarity too.

Found and discussed prometheus/prometheus#15731 (comment)

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Fixed comments; optimized not needed copy for om and text.

Signed-off-by: bwplotka <bwplotka@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
…#15967)

This will merge on green all non-conflicting dependabot PRs.

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: amanycodes <amanycodes@gmail.com>
This is very useful when piping the input file to stdin and then using
/dev/stdin as the input file. e.g.

    xzcat dump.xz |
    	promtool tsdb create-blocks-from openmetrics /dev/stdin /tmp/data

Signed-off-by: Nicolas Peugnet <nicolas.peugnet@lip6.fr>
# Conflicts:
#	.github/workflows/ci.yml
@CLAassistant
Copy link
CLAassistant commented Mar 12, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 11 committers have signed the CLA.

✅ beorn7
✅ charleskorn
❌ mmorel-35
❌ jub0bs
❌ Codelax
❌ bwplotka
❌ juliusv
❌ amanycodes
❌ n-peugnet
❌ jgbernalp
❌ machine424
You have signed the CLA already but the status is still pending? Let us recheck it.

@charleskorn charleskorn marked this pull request as ready for review March 12, 2025 02:34
@charleskorn charleskorn merged commit 4c5f375 into main Mar 13, 2025
8 of 9 checks passed
@charleskorn charleskorn deleted the charleskorn/update-prometheus branch March 13, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0