set ttlAutopurge to true as ttl is set for codemirror prometheus client cache #16024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt cache Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Nexucis
approved these changes
Feb 12, 2025
kylestang
pushed a commit
to kylestang/prometheus
that referenced
this pull request
Feb 12, 2025
…nt cache (prometheus#16024) Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
ttlAutopurgeoption totrueas attlis provided. Follows the lru-cache documentation: https://github.com/isaacs/node-lru-cache/blob/65c9971e3fef123ff0f17d67add53b2d99b461b0/src/index.ts#L698Fixes #16023