8000 Bump libhdate depndency by tsvi · Pull Request #42396 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump libhdate depndency #42396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2020
Merged

Bump libhdate depndency #42396

merged 2 commits into from
Oct 26, 2020

Conversation

tsvi
Copy link
Contributor
@tsvi tsvi commented Oct 26, 2020 •
edited
Loading

This version fixes an important bug found by @amitfin in py-libhdate/py-libhdate#78

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@springstan
Copy link
Member

Please run python3 -m script.gen_requirements_all to update all requirement files.

@amitfin
Copy link
Contributor
amitfin commented Oct 26, 2020

Please note that I've included this change in #42328
We can do it also as 2 separate PRs. I don't have a preference.

tsvi and others added 2 commits October 26, 2020 13:55
@balloob
Copy link
Member
balloob commented Oct 26, 2020

Let's do two separate PRs so this one can be included in 117 going out on Wednesday since it's just a bug fix.

@balloob balloob added this to the 0.117.0 milestone Oct 26, 2020
@balloob balloob merged commit 80e8068 into home-assistant:dev Oct 26, 2020
balloob added a commit that referenced this pull request Oct 26, 2020
@tsvi @balloob
Bump libhdate depndency (#42396)
bcd2ae7 
* Bump libhdate depndency

This version fixes an important bug found by @amitfin in py-libhdate/py-libhdate#78

* Update reqs

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@tsvi tsvi deleted the patch-2 branch October 26, 2020 19:36
@tsvi
Copy link
Contributor Author
tsvi commented Oct 26, 2020

Thanks @balloob for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency-bump Hacktoberfest integration: jewish_calendar small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.117.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tsvi @springstan @amitfin @balloob @homeassistant
0