8000 Update "issur_melacha_in_effect" via time tracking by amitfin · Pull Request #42328 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update "issur_melacha_in_effect" via time t 8000 racking #42328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

Update "issur_melacha_in_effect" via time tracking #42328

wants to merge 35 commits into from

Conversation

amitfin
Copy link
Contributor
@amitfin amitfin commented Oct 25, 2020 •
edited
Loading

Breaking change

Proposed change

binary_sensor.jewish_calendar_issur_melacha_in_effect used the regular polling mode.
It means that it gets updated within the polling window, and is less precise.
With this change, the binary sensor gets updated on the exact time it should.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
N/A

Additional information

The binary sensor didn't update on the exact time it was supposed to. Fixed that.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

10000

amitfin added 26 commits October 5, 2020 12:00
@amitfin
Add files via upload
d6cbe1c
@amitfin
Add files via upload
dca2a38
@amitfin
Changed state to be on/off
2049917
@amitfin
Updated the cache file
8d90f4e
@amitfin
Merge branch 'amitfin-input-schedule' of https://github.com/amitfin/core
064a387 
 into amitfin-input-schedule
@amitfin
Updating cache
30363ac
@amitfin
Update CODEOWNERS
11d2e48
@amitfin
Fixed setting off an entire on period
818370d
@amitfin
Add "input_schedule" to "default_config".
27cb3f9
@amitfin
Renamed "schedule" to "timetable"
7ce12c8
@amitfin
Fixed typos
9706b60
@amitfin
Fixed translation
52938e6
@amitfin
Fixed "reload"
117c3d0
@amitfin
Move to events model
e7f8ff2
@amitfin
Use capital letters for the states
f806eb8
@amitfin
Re-trigger checks
45a2099
@amitfin
Merge branch 'amitfin-input-schedule' of https://github.com/amitfin/core
3139cde 
 into amitfin-input-schedule
@amitfin
Add "reconfig" service
42b86a7
@amitfin
Add "reconfig" description
ac3e77c
@amitfin
Rerun tests
23604fd
@amitfin
Merge branch 'amitfin-input-schedule' of https://github.com/amitfin/core
003f9e5 
 into amitfin-input-schedule
@amitfin
Merge branch 'dev' into amitfin-input-schedule
52771b9
@amitfin
Update manifest.json
a3e23d5
@amitfin
Use @pytest.mark.parametrize
06988c4
@amitfin
Use dt_util
0bd2f0c
@amitfin
Update "issur_melacha_in_effect" via time tracking
25b46c1
@yuvalabou
Copy link
Contributor

Great work!

@amitfin amitfin mentioned this pull request Oct 26, 2020
Merged
4 tasks
tsvi
tsvi approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor
@tsvi tsvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@amitfin
Copy link
Contributor Author
amitfin commented Oct 26, 2020
  1. 2 unrelated branches were mistakenly merged, so I manually deleted all unrelated files from the other branch. (Sorry about the mess).
  2. The version of hdate was bumped to 0.9.12 to include the following fix which is requi 8000 red by the this PR: py-libhdate/py-libhdate@bcc0cd3

@amitfin amitfin mentioned this pull request Oct 26, 2020
Merged
21 tasks
@amitfin
Copy link
Contributor Author
amitfin commented Oct 27, 2020

Closing this PR and moving the changes to a clean branch with this PR: #42485

@amitfin amitfin closed this Oct 27, 2020
@amitfin amitfin mentioned this pull request Oct 27, 2020
Merged
21 tasks
@amitfin amitfin deleted the jewish-binary-sensor-time-tracking branch October 28, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsvi tsvi tsvi approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality has-tests integration: jewish_calendar invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitfin @yuvalabou @tsvi @homeassistant
0