8000 Support more errors to better do retries in UniFi by Kane610 · Pull Request #44108 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support more errors to better do retries in UniFi #44108

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Support more errors to better do retries in UniFi #44108

merged 1 commit into from
Dec 10, 2020

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Dec 10, 2020 •
edited
Loading

Breaking change

Proposed change

Kane610/aiounifi@v25...v26 Most of the library changes are related to tests
Handle 502 and 503 signals from proxy services typically affected when UniFi Controller restart during an upgrade.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver< 8000 /li>
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 1.0.0 milestone Dec 10, 2020
@frenck frenck merged commit 9651d1b into home-assistant:dev Dec 10, 2020
frenck pushed a commit that referenced this pull request Dec 10, 2020
@Kane610 @frenck
Support more errors to better do retries in UniFi (#44108)
3986df6
@Kane610
Copy link
Member Author
Kane610 commented Dec 10, 2020

Woohoo! Thanks @jjlawren and @frenck 🎉

@Kane610 Kane610 deleted the unifi-handle_more_errors branch December 10, 2020 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@jjlawren jjlawren jjlawren approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency has-tests integration: unifi small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] UniFi Integration doesn't update after connectivity failure
4 participants
@Kane610 @frenck @jjlawren @homeassistant
0