Fix "notify.events" trim() issue + add initial tests #48928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the change was introduced in #47133 in current release and clearly not tested, we should just remove it |
21 tasks
balloob
approved these changes
Apr 9, 2021
balloob
added a commit
that referenced
this pull request
Apr 9, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Merged
| """Test notify.events service.""" | ||
| notify_calls = async_mock_service(hass, DOMAIN, "events") | ||
|
|
||
| await hass.services.async_call( |
There was a problem hiding this comment.
This is just testing the mock service we registered above. We're not testing the integration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Replace
trim()withstrip(). Added some initial testing setup.Note: I do not actually use the integration myself, so I cannot actually test it at runtime.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: