8000 Move recorder.py import to runtime by uvjustin · Pull Request #52682 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move recorder.py import to runtime #52682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

Move recorder.py import to runtime #52682

merged 1 commit into from
Jul 8, 2021

Conversation

uvjustin
Copy link
Contributor
@uvjustin uvjustin commented Jul 7, 2021

Proposed change

Stream should be able to be imported without the av dependency installed. #51837 breaks this by introducing a top level import from recorder.py. This PR moves the import to runtime as is already done elsewhere in the file.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hunterjm, @allenporter, mind taking a look at this pull request as its been labeled with an integration (stream) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added this to the 2021.7.1 milestone Jul 8, 2021
frenck
frenck approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @uvjustin 👍

@frenck frenck merged commit b021e2e into home-assistant:dev Jul 8, 2021
@ludeeus ludeeus mentioned this pull request Jul 8, 2021
Closed
tkdrob pushed a commit to tkdrob/core that referenced this pull request Jul 8, 2021
@uvjustin @tkdrob
Move recorder.py import to runtime (home-assistant#52682)
0202e44
frenck pushed a commit that referenced this pull request Jul 8, 2021
@uvjustin @frenck
Move recorder.py import to runtime (#52682)
286c068
@frenck frenck mentioned this pull request Jul 8, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2021
@uvjustin uvjustin deleted the fix-av-import-stream branch November 7, 2021 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@allenporter allenporter allenporter approved these changes

Assignees

@hunterjm hunterjm

@allenporter allenporter

Labels
bugfix by-code-owner cherry-picked cla-signed core integration: stream small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.7.1
Development

Successfully merging this pull request may close these issues.

Setup failed for cloud: Unable to import component: No module named 'av' - in 2021.7.0 Core
5 participants
@uvjustin @frenck @allenporter @hunterjm @homeassistant
0