Feature/add mikrotik device tracker #7366
Conversation
|
@LvivEchoes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
|
Thanks! |
|
Hello there! I found this and been trying to use it for the last week. Today I decided to check the code and found out that I was checking the wrong PR (the one that was using tikapy #5830 ), and this only relies on wireless clients. As in my case my router doesn't have wireless capabilities, I want to use only the DHCP output. I quick-patched the module on my computer and it's working, but want to ask: is it OK if I submit a PR for this? or you prefer to keep it just wireless? |
|
Hi guys. I think I fixed this issues in
#7690. Couldn't you
try this version and let me know if all goes great now?
2017-05-20 9:52 GMT+03:00 Luar Roji <notifications@github.com>:
… Hello there!
I found this and been trying to use it for the last week. Today I deci
8000
ded
to check the code and found out that I was checking the wrong PR (the one
that was using tikapy), and this only relies on wireless clients.
As in my case my router doesn't have wireless capabilities, I want to use
only the DHCP output.
I quick-patched the module on my computer and it's working, but want to
ask: is it OK if I submit a PR for this? or you prefer to keep it just
wireless?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7366 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AaAvZfhCF4P70BQ6v9bcDsGxnAu-Kn6Lks5r7o2ggaJpZM4NMVQI>
.
|
|
DHCP information source is not actually right approach to use it
as presence sensor, cause if lease time is big, HA can't track your
devices. HA also can't track any device, which had static lease binding.
Despite the above, I create PR to extend functionality, but I described all
warnings.
#7690
2017-05-20 9:52 GMT+03:00 Luar Roji <notifications@github.com>:
… Hello there!
I found this and been trying to use it for the last week. Today I decided
to check the code and found out that I was checking the wrong PR (the one
that was using tikapy), and this only relies on wireless clients.
As in my case my router doesn't have wireless capabilities, I want to use
only the DHCP output.
I quick-patched the module on my computer and it's working, but want to
ask: is it OK if I submit a PR for this? or you prefer to keep it just
wireless?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7366 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AaAvZfhCF4P70BQ6v9bcDsGxnAu-Kn6Lks5r7o2ggaJpZM4NMVQI>
.
|
|
Hello @LvivEchoes ! Thanks for your new PR. I've configured lease time on 10 minutes, so it's not dramatic. But, one thing I did on my version was to filter the dhcp-table if "active-address" is present. I don't know if that field is present on all the routers, but on my case it allows me to have static dhcp leases and only 'detect presence' when the device is alive. I did something like this: If this |
|
@cyberplant nice catch! I should test it in my env and if all is ok, I create PR with this improvement! |
|
Perfect, thanks @LvivEchoes. I've been using it at home and it's working fine. |
We only want to know which of the DHCP clients are indeed active. For example: I've a table of static DHCP leases with most of the IPs of my network, so this module is always detecting them as present. With my patch only the active ones will be detected as present. I already mentioned here: #7366 (comment)
We only want to know which of the DHCP clients are indeed active. For example: I've a table of static DHCP leases with most of the IPs of my network, so this module is always detecting them as present. With my patch only the active ones will be detected as present. I already mentioned here: home-assistant#7366 (comment)
Description:
Add Mikrotik routers support as device tracker
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2522
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.