Mikrotik: Continue tracking device over dhcp lease table if wireless adaptor not installed #7690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LvivEchoes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff to be a potential reviewer. |
This was referenced May 21, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If user would like to track mikrotik device without wireless interface installed, dhcp lease table will use as presence detector source.
Additional info: Dhcp leases/arp table/etc are not 100% right approach for using them as presence detector. If you going to use this approach anyway, please decrease dhcp lease time as much as possible. For home purposes, i would recommend to set it between 5 and 10 minutes. Also don't use static leases for devices, which you like to work with.
Related issue (if applicable): fixes #7604
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass