8000 Revert withings library change by MartinHjelmare · Pull Request #27385 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert withings library change #27385 < 8000 /h1>
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Revert withings library change #27385

merged 1 commit into from
Oct 10, 2019

Conversation

MartinHjelmare
Copy link
Member

Breaking Change:

Description:

This reverts commit 0714763.

The new withings library has a non matching version specifier in its setup.py:
https://github.com/vangorra/python_withings_api/blob/03be3409cac74e03b7fcc96706f24c5a6bd54e9a/setup.py#L11

Our release build is currently failing due to this mismatch.

Related issue (if applicable):
fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):



Checklist:


    

  •  The code change is tested and works locally.
    • 

  •  Local tests pass with tox. Your PR cannot be merged unless tests pass
    • 

  •  There is no commented out code in this PR.
    • 

  •  I have followed the development checklist
    • 



If user exposed functionality or configuration variables are added/changed:



If the code communicates with devices, web services, or third-party tools:


    

  •  The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
    • 

  •  New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
    • 

  •  Untested files have been added to .coveragerc.
    • 



If the code does not interact with devices:


    

  •  Tests have been added to verify that the new code works.
    • 


    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  





       
            



      

  
        





      

  
            


    







      

  
      



  

  @probot-home-assistant





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  
    

  




      


        


  
    

      
          
Hey there @vangorra, mind taking a look at this pull request as its been labeled with a integration (withings) you are listed as a codeowner for? Thanks!

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @frenck





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

      

      
            frenck
  

      

      

      commented


        Oct 10, 2019


      
    


  




      


        


  
    

      
          
Some additional information. PR that introduced this: #27310


Our build error:


Collecting withings-api==2.0.0b7 (from -r homeassistant/requirements_all.txt (line 1974))
  ERROR: Could not find a version that satisfies the requirement withings-api==2.0.0b7 (from -r homeassistant/requirements_all.txt (line 1974)) (from versions: 0.0.0a0)
ERROR: No matching distribution found for withings-api==2.0.0b7 (from -r homeassistant/requirements_all.txt (line 1974))


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @frenck





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

      

      
            frenck
  

      

      

      commented


        Oct 10, 2019


      
    


  




      


        


  
    

      
          
⚠️  Please hold with merging this PR until we are sure we are going this route in order to fix the 0.100 release. Thanks.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @vangorra





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          
Interesting. Why does the release build have an issue with how setup.py sets the version? I thought HA was pulling the pypi package which contains egg metadata to provide version and such.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @frenck





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

      

      
            frenck
  

      

      

      commented


        Oct 10, 2019


      
    


  




      


        


  
    

      
          
@vangorra yes, we rely on PyPi for the source, however, we do build our own wheels for distribution.

Building a wheel with the current state of the library, causes the build version to be 0.0.0a0.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  

    
  

  



        @bramkragten
  bramkragten



        merged commit c188ecf
      into

      
  
    dev
  


    Oct 10, 2019

  







  

  
  

  
      @delete-merged-branch
  delete-merged-branch
bot

    
    deleted the
    
      
        revert-withings-library-change
    
    branch

    October 10, 2019 12:21    
    




    

    

      
    

    


      

          @bramkragten
bramkragten




          added this to the   0.100.1 milestone


      Oct 10, 2019

    

  








      

  
      



  

  @frenck





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

      

      
            frenck
  

      

      

      commented


        Oct 10, 2019


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
  
        
      Loading


  
    
  



    


  




      


        


  
    

      
          
@vangorra Output from the creation of the wheel:


image

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          


  
    
  
  

    
  bramkragten 

      pushed a commit
      that referenced
      this pull request

    
      Oct 10, 2019
    
    

      


  

    

      


  

      
        @MartinHjelmare
      
        @bramkragten
  





      

        
          Revert "Fix connection issues with withings API by switching to a mai…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          65372da
        
      

    

  

    

      
…ntained codebase (#27310)" (#27385)

This reverts commit 0714763.

    




    

  









      

  
      



  

  @vangorra





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          
The version being 0.0.0a when building a wheel makes sense as that version is expected to come from an environment variable, when no version is provided, it defaults to 0.0.0a0. This was intended to make release of the package simpler and avoid redundant commits. I'll see if I can work something else out.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  

    
  


  

      

    @vangorra
vangorra



    mentioned this pull request
    
      Oct 10, 2019
    





  


  

      
  
  Closed

  







  




    

    

      
    

    


      

          @lock
lock
bot



        locked and limited conversation to collaborators


      Oct 11, 2019

    

  












  
  

    

      

  




      


    


    

      

             

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  


      

    

  




  
          




      

  

    
    

    

  

    Reviewers
  


    

    No reviews






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    cla-signed

  

    Hacktoberfest

  

    has-tests

  

    integration: withings

  

    small-pr

  PRs with less than 30 lines.








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    0.100.1
  





    
      
          


  

    

      
        

          
    

    Development
  



            


Successfully merging this pull request may close these issues.



  
  
  



      
    

  




      

    

  
      

  

    

      5 participants
    

    

        
          @MartinHjelmare 
        
          @frenck 
        
          @vangorra 
        
          @bramkragten 
        
          @homeassistant 
    

  






    

    




    







  

    

  

  


    



  





    

  


  


          



    



  

    

    

    





    


    

    

  



0