8000 Discover controllable Plex clients using plex.tv by jjlawren · Pull Request #36857 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Discover controllable Plex clients using plex.tv #36857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2020
Merged

Discover controllable Plex clients using plex.tv #36857

merged 2 commits into from
Jun 17, 2020

Conversation

jjlawren
Copy link
Contributor

Proposed change

The integration previously relied solely on the Plex server to report back known controllable Plex clients for use as media_player entities. The Plex server can only discover these clients using a proprietary UDP broadcast protocol (GDM) which can fail to work in many fairly standard setups (e.g., Plex running in a container).

This PR additionally queries a plex.tv endpoint to find clients associated with the current Plex account that have not already been locally discovered.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@jjlawren jjlawren marked this pull request as draft June 16, 2020 20:42
@jjlawren jjlawren marked this pull request as ready for review June 17, 2020 01:53
@balloob balloob merged commit d5cc320 into home-assistant:dev Jun 17, 2020
@jjlawren jjlawren mentioned this pull request Jun 17, 2020
Merged
16 tasks
@jjlawren jjlawren deleted the plextv_resource_discovery branch June 17, 2020 19:48
@jjlawren jjlawren mentioned this pull request Jun 25, 2020
Merged
16 tasks
@jjlawren jjlawren mentioned this pull request Jul 7, 2020
Fix missing Plex account mocks in tests #37591
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: plex new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjlawren @balloob @homeassistant
0