8000 Fix Plex when using local tokenless authentication by jjlawren · Pull Request #37096 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix P 8000 lex when using local tokenless authentication #37096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2020
Merged

Fix Plex when using local tokenless authentication #37096

merged 4 commits into from
Jun 26, 2020

Conversation

jjlawren
Copy link
Contributor
@jjlawren jjlawren commented Jun 25, 2020 •
edited
Loading

Proposed change

An additional call which requires a valid Plex token was added in #36857. For users that rely on local tokenless authentication (by allowed IP address) this could cause problems during setup. This PR adds additional guards when this situation is detected.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@jjlawren jjlawren added this to the 0.112.0 milestone Jun 25, 2020
@jjlawren jjlawren marked this pull request as draft June 25, 2020 17:06
@jjlawren jjlawren marked this pull request as ready for review June 25, 2020 20:26
@balloob balloob merged commit fd1a8dd into home-assistant:dev Jun 26, 2020
balloob pushed a commit that referenced this pull request Jun 26, 2020
@jjlawren @balloob
Fix Plex when using local tokenless authentication (#37096)
1508d7a
@jjlawren jjlawren deleted the plex_tokenless_guards branch June 26, 2020 03:49
@jjlawren jjlawren mentioned this pull request Jun 26, 2020
Merged
20 tasks
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@PeteRager @c0ffeeca7
Media player browse media action documentation (home-assistant#37096)
980c2fc 
* initial draft

* update

* add better examples per coderabbit

* add better examples per coderabbit

* remove blank lines

* add text

* add response description

* more coderabbit suggestions

* more coderabbit suggestions

* style nitpicks

---------

Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: plex small-pr PRs with less than 30 lines.
Projects
None yet
44F0
Milestone
0.112.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jjlawren @balloob @homeassistant
0