IGNT-67 Added Binary res for patient data view control #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for excluding Binary resources based on patient data view control in the everything operation and updates related test fixtures.
- Remove Binary entry from the expected bundle and adjust the total count and query display.
- Add a Binary reference in the consent fixture.
- Implement exclusion logic in
EverythingHelperfor Binary resources.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/everything/person_or_patient_non_clinical/fixtures/expected/expected_patient_everything_with_patient_scope_and_exclude_res.json | Remove the Binary resource entry, decrement total, and update the displayed query string. |
| src/tests/everything/person_or_patient_non_clinical/fixtures/Consent/consent1.json | Add a new Binary reference entry to the consent fixture. |
| src/operations/everything/everythingHelper.js | Add id:not filtering for Binary resources using the exclusion map. |
Comments suppressed due to low confidence (1)
src/operations/everything/everythingHelper.js:592
- Add a unit test to verify that when
resourceTypeis 'Binary' and the exclusion map contains IDs, thebaseArgs['id:not']filter is correctly set.
if (resourceType === 'Binary' && resourceToExcludeIdsMap[resourceType]?.length > 0) {
| @@ -588,6 +588,11 @@ class EverythingHelper { | |||
| _includeHidden: parsedArgs._includeHidden | |||
| }; | |||
|
|
|||
| // for non-clinical resources, only binary support patient data view control | |||
There was a problem hiding this comment.
[nitpick] Clarify this comment to explain the intention, e.g., "// Exclude Binary resources based on patient data view control when exclude IDs are provided".
Suggested change
| // for non-clinical resources, only binary support patient data view control | |
| // Exclude Binary resources based on patient data view control when specific resource IDs are provided. |
Copilot uses AI. Check for mistakes.
nirbhaykumar1999
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.