8000 IGNT-67 Added Binary res for patient data view control by shubhamgoel24 · Pull Request #1890 · icanbwell/fhir-server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

IGNT-67 Added Binary res for patient data view control #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

IGNT-67 Added Binary res for patient data view control #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/operations/everything/everythingHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,11 @@ class EverythingHelper {
_includeHidden: parsedArgs._includeHidden
};

// for non-clinical resources, only binary support patient data view control
Copy link
Preview
Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Clarify this comment to explain the intention, e.g., "// Exclude Binary resources based on patient data view control when exclude IDs are provided".

Suggested change
// for non-clinical resources, only binary support patient data view control
// Exclude Binary resources based on patient data view control when specific resource IDs are provided.

Copilot uses AI. Check for mistakes.

if (resourceType === 'Binary' && resourceToExcludeIdsMap[resourceType]?.length > 0) {
baseArgs["id:not"] = resourceToExcludeIdsMap[resourceType].join(',');
}

// if explain query, don't break in chunks as will be limit to single resource later
const idChunks = explain
? [ids]
Expand Down
7 changes: 7 additions & 0 deletions src/tests/everything/person_or_patient_non_clinical/fixtures/Consent/consent1.json
View file
Open in desktop
95A1
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@
"reference": {
"reference": "Procedure/dc56f59d-71e5-4b11-98cd-9b9a0dee730c"
}
},
{
"id": "16d5da29-2aa2-5b13-84c9-44c574b1439a",
"meaning": "instance",
"reference": {
"reference": "Binary/2be6f9aa-62b1-509c-bafc-28f4665fa465"
}
}
]
}
Expand Down
35 changes: 2 additions & 33 deletions ...cal/fixtures/expected/expected_patient_everything_with_patient_scope_and_exclude_res.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading
0