8000 4.0.0 by gmlwhdtjd · Pull Request #287 · ioskrew/SwiftLayout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

4.0.0 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2024
Merged

4.0.0 #287

merged 10 commits into from
Oct 18, 2024

Conversation

gmlwhdtjd
Copy link
Contributor

No description provided.

gmlwhdtjd and others added 8 commits June 27, 2024 18:11
* remove SwiftLayoutUtil

* Update swift.yml for remove SwiftLayoutUtil
* apply SwiftLint

* fixed lint errors and warnings

* Update swift.yml
* Remove deprecated methods for easy migration

* changed to only work in the Main UI Thread via MainActor

* add private Activation store for deinit

* Revert "add private Activation store for deinit"

This reverts commit 3b290c1.

* Refactor Activation.deinit()

- Removed the `deactivate()` function.
- Updated `deactivateConstraints` to be a static function that takes `constraints` as an argument.
- Updated `deactivateViews` to be a static function that takes `views` as an argument.
- Modified the `deinit` of `Activation` to retrieve `views` and `constraints`, passing them to `deactivateConstraints` and `deactivateViews` within a `MainActor` Task.

* restore the `deactivate()` function.

* Migrating test from XCTest to Testing

* Migration ImplementationTests from XCTest to Testing

* Migration ReferenceTests from XCTest to Testing

* Migration AnchorsImplementationTests from XCTest to Testing

* Migration LayoutDSLTests from XCTest to Testing

* fix misspelling

* Migration LayoutableTests from XCTest to Testing

* update isEqual function to ignore order of elements of constraints
using isEqual function for compare constraints in LayoutableTests

* modify name of LayoutableView to LayoutableViewTest and using test
context instead LayoutableTests

* Migration AnchorsDSLTests from XCTest to Testing

* update LayoutableTests for not use LayoutableView to test body

* add swift version 6 to SwiftLayout
add swift verions 5 to SwiftLayoutUtil

* disable SwiftLayoutUtilsTests until migrate to swift language version 6

* Deleted TestAnchorsBuilder and updated AcnhorsDSLTests, LayoutableTests

* Fix package error after merge

* Fix Lint Errors and Warnings after merge

* add a Deactivator to deactivate properly in deinit without thread issues

* Remove unnecessary @retroactive

* Update swift.yml for xcode16

---------

Co-authored-by: oozoofrog <oozoofrog@gmail.com>
Co-authored-by: jaychoi <jay.choi@kakaocorp.com>
@gmlwhdtjd gmlwhdtjd requested a review from oozoofrog October 18, 2024 03:28
oozoofrog
oozoofrog previously approved these changes Oct 18, 2024
Copy link
Collaborator
@oozoofrog oozoofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator
@oozoofrog oozoofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2 👍

@gmlwhdtjd gmlwhdtjd merged commit 8ffc171 into main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0