-
Notifications
You must be signed in to change notification settings - Fork 12
4.0.0 #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove SwiftLayoutUtil * Update swift.yml for remove SwiftLayoutUtil
* apply SwiftLint * fixed lint errors and warnings * Update swift.yml
* Remove deprecated methods for easy migration * changed to only work in the Main UI Thread via MainActor * add private Activation store for deinit * Revert "add private Activation store for deinit" This reverts commit 3b290c1. * Refactor Activation.deinit() - Removed the `deactivate()` function. - Updated `deactivateConstraints` to be a static function that takes `constraints` as an argument. - Updated `deactivateViews` to be a static function that takes `views` as an argument. - Modified the `deinit` of `Activation` to retrieve `views` and `constraints`, passing them to `deactivateConstraints` and `deactivateViews` within a `MainActor` Task. * restore the `deactivate()` function. * Migrating test from XCTest to Testing * Migration ImplementationTests from XCTest to Testing * Migration ReferenceTests from XCTest to Testing * Migration AnchorsImplementationTests from XCTest to Testing * Migration LayoutDSLTests from XCTest to Testing * fix misspelling * Migration LayoutableTests from XCTest to Testing * update isEqual function to ignore order of elements of constraints using isEqual function for compare constraints in LayoutableTests * modify name of LayoutableView to LayoutableViewTest and using test context instead LayoutableTests * Migration AnchorsDSLTests from XCTest to Testing * update LayoutableTests for not use LayoutableView to test body * add swift version 6 to SwiftLayout add swift verions 5 to SwiftLayoutUtil * disable SwiftLayoutUtilsTests until migrate to swift language version 6 * Deleted TestAnchorsBuilder and updated AcnhorsDSLTests, LayoutableTests * Fix package error after merge * Fix Lint Errors and Warnings after merge * add a Deactivator to deactivate properly in deinit without thread issues * Remove unnecessary @retroactive * Update swift.yml for xcode16 --------- Co-authored-by: oozoofrog <oozoofrog@gmail.com> Co-authored-by: jaychoi <jay.choi@kakaocorp.com>
oozoofrog
previously approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
oozoofrog
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.