JESI-2210 #14
Merged
JESI-2210 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axrs
previously approved these changes
Sep 3, 2018
axrs
previously approved these changes
Sep 3, 2018
AndreTheHunter
commented
Sep 4, 2018
src/io/jesi/backpack/string.cljc
Outdated
| (defn ->snake_case [s] | ||
| (some-> s | ||
| ->kebab-case | ||
| (string/replace #"-" "_"))) |
There was a problem hiding this comment.
replace chars instead of creating regex:
(string/replace \- \_)| 'a-snail-can-sleep-for-three-years | ||
| 'slugsHaveFourNoses) | ||
| (is (= "a_snail_can_sleep_for_three_years" a-snail-can-sleep-for-three-years)) | ||
| (is (= "slugs_have_four_noses" slugsHaveFourNoses)))) |
| (is (true? (bp/macro? `defconsts))))) | ||
|
|
||
| (testing "transforms the symbol values with the given function" | ||
| (defconsts bp/->snake_case |
There was a problem hiding this comment.
Does composing the body-fn work?
Since we may want a screaming snake_case, the easiest would be to: (comp string/upper-case bp/->snake_case)
| `(do ~@(for [s symbols | ||
| :let [name (second s) | ||
| body (str name)]] | ||
| `(def ~name (~body-fn ~body))))) |
There was a problem hiding this comment.
May need to extract body-fn to a variable outside the loop, in case it's composed (see comment below)
|
👍 |
axrs
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JESI-2210
0.0.13 already taken https://circleci.com/gh/jesims/backpack/516