JESI-2210 #13
Merged
JESI-2210 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreTheHunter
commented
Sep 3, 2018
| @@ -14,7 +15,8 @@ | |||
| (defn js->clj | |||
| "Transforms JavaScript to ClojureScript converting keys to kebab-case keywords" | |||
| [x] | |||
| (transform-keys ->kebab-case-key (clojure.core/js->clj x :keywordize-keys true))) | |||
| (when-let [clj (some-> x (clojure.core/js->clj :keywordize-keys true))] | |||
| (transform-keys ->kebab-case-key clj))) | |||
There was a problem hiding this comment.
Slight optimization to skip if nil
| [x] | ||
| (js->clj (js/JSON.parse x))) | ||
| [s] | ||
| (when-not (string/blank? s) |
There was a problem hiding this comment.
Blank is invalid JSON, so added check
Inspired by https://github.com/r0man/cljs-http/blob/master/src/cljs_http/util.cljs#L60
| (assert-eq true "false") | ||
| (assert-eq "" "\"\"") | ||
| (assert-eq 3.14 "3.14") | ||
| (assert-eq 42 "42")))) |
There was a problem hiding this comment.
Test all the things!
axrs
suggested changes
Sep 3, 2018
| (assert-eq [] "[]") | ||
| (assert-eq nil "null") | ||
| (assert-eq true "true") | ||
| (assert-eq true "false") |
|
|
||
| (testing "parses empty and literal values" | ||
| (let [assert-eq (fn [expected s] | ||
| (is (= expected) (bp/json->clj s)))] |
axrs
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JESI-2210
https://github.com/jesims/jesi-web/pull/595
https://github.com/jesims/build-scripts/pull/95
https://github.com/jesims/jesi/pull/810