fix: avoid double-submission in password change and recovery code scr… #29578
js-ci.yml
on: pull_request
Admin Client
33s
UI Shared
42s
Account UI
56s
Admin UI
1m 52s
Matrix: Admin UI E2E
Annotations
2 errors, 29 warnings, and 1 notice
[chromium] › test/identity-providers/oidc.spec.ts:82:3 › Edit OIDC Provider › should add OIDC mapper of type Attribute Importer:
js/apps/admin-ui/test/utils/masthead.ts#L5
1) [chromium] › test/identity-providers/oidc.spec.ts:82:3 › Edit OIDC Provider › should add OIDC mapper of type Attribute Importer
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)
Locator: getByTestId('last-alert')
Expected string: "Mapper created successfully."
Received: <element(s) not found>
Call log:
- expect.toHaveText with timeout 5000ms
- waiting for getByTestId('last-alert')
at utils/masthead.ts:5
3 |
4 | export async function assertNotificationMessage(page: Page, message: string) {
> 5 | await expect(page.getByTestId("last-alert")).toHaveText(message);
| ^
6 | }
7 |
8 | function getActionToggleButton(page: Page) {
at assertNotificationMessage (/home/runner/work/keycloak/keycloak/js/apps/admin-ui/test/utils/masthead.ts:5:48)
at /home/runner/work/keycloak/keycloak/js/apps/admin-ui/test/identity-providers/oidc.spec.ts:88:11
|
[chromium] › test/user-federation/kerberos.spec.ts:180:5 › User Fed Kerberos tests › Edit Kerberos provider › Should edit existing Kerberos provider and cancel:
js/apps/admin-ui/test/user-federation/kerberos.spec.ts#L192
2) [chromium] › test/user-federation/kerberos.spec.ts:180:5 › User Fed Kerberos tests › Edit Kerberos provider › Should edit existing Kerberos provider and cancel
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)
Locator: locator('#kc-cache-policy')
Expected string: "DEFAULT"
Received string: "NO_CACHE"
Call log:
- expect.toHaveText with timeout 5000ms
- waiting for locator('#kc-cache-policy')
9 × locator resolved to <button type="button" id="kc-cache-policy" aria-expanded="false" data-ouia-safe="true" aria-label="Cache policy" data-ouia-component-type="PF5/MenuToggle" class="pf-v5-c-menu-toggle pf-m-full-width" data-ouia-component-id="OUIA-Generated-MenuToggle-8">…</button>
- unexpected value "NO_CACHE"
190 | await clickUserFederationCard(page, firstKerberosName);
191 |
> 192 | await expect(page.locator("#kc-cache-policy")).toHaveText(defaultPolicy);
| ^
193 | });
194 |
195 | test("Should disable an existing Kerberos provider", async ({ page }) => {
at /home/runner/work/keycloak/keycloak/js/apps/admin-ui/test/user-federation/kerberos.spec.ts:192:54
|
UI Shared:
js/libs/ui-shared/src/context/KeycloakContext.tsx#L46
Unexpected reassignment of a variable which was defined outside of the component. Components and hooks should be pure and side-effect free, but variable reassignment is a form of side-effect. If this variable is used in rendering, use useState instead. (https://react.dev/reference/rules/components-and-hooks-must-be-pure#side-effects-must-run-outside-of-render)
|
UI Shared:
js/libs/ui-shared/src/context/KeycloakContext.tsx#L81
React Hook useEffect has a missing dependency: 'environment.scope'. Either include it or remove the dependency array
|
UI Shared:
js/libs/ui-shared/src/controls/table/KeycloakDataTable.tsx#L151
React Hook useEffect has a missing dependency: 'rowsSelectedOnPage.length'. Either include it or remove the dependency array
|
UI Shared:
js/libs/ui-shared/src/controls/table/KeycloakDataTable.tsx#L489
React Hook useMemo has missing dependencies: 'convertToColumns', 'getNodeText', 'isPaginated', and 'unPaginatedData'. Either include them or remove the dependency array
|
UI Shared:
js/libs/ui-shared/src/select/SingleSelect.tsx#L52
This function accesses a ref value (the `current` property), which may not be accessed during render. (https://react.dev/reference/react/useRef)
|
UI Shared:
js/libs/ui-shared/src/select/SingleSelect.tsx#L52
Ref values (the `current` property) may not be accessed during render. (https://react.dev/reference/react/useRef)
|
UI Shared:
js/libs/ui-shared/src/user-profile/MultiInputComponent.tsx#L72
React Hook useMemo has a missing dependency: 'defaultValue'. Either include it or remove the dependency array
|
UI Shared:
js/libs/ui-shared/src/user-profile/MultiInputComponent.tsx#L99
React Hook useEffect has a missing dependency: 'name'. Either include it or remove the dependency array
|
UI Shared:
js/libs/ui-shared/src/utils/useFetch.ts#L43
React Hook useEffect was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies
|
UI Shared:
js/libs/ui-shared/src/utils/useFetch.ts#L43
React Hook useEffect has missing dependencies: 'adminClientCall', 'callback', and 'showBoundary'. Either include them or remove the dependency array. If 'adminClientCall' changes too often, find the parent component that defines it and wrap that definition in useCallback
|
Account UI:
js/apps/account-ui/src/oid4vci/Oid4Vci.tsx#L69
React Hook useEffect has missing dependencies: 'context', 'credentialsIssuer', 'initialSelected', and 'selectOptions'. Either include them or remove the dependency array
|
Account UI:
js/apps/account-ui/src/resources/EditTheResource.tsx#L42
React Hook useEffect has missing dependencies: 'permissions' and 'reset'. Either include them or remove the dependency array
|
Account UI:
js/apps/account-ui/src/resources/ShareTheResource.tsx#L72
React Hook useEffect has a missing dependency: 'append'. Either include it or remove the dependency array
|
Account UI:
js/apps/account-ui/src/utils/usePromise.ts#L73
React Hook useEffect was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies
|
Account UI:
js/apps/account-ui/src/utils/usePromise.ts#L73
React Hook useEffect has missing dependencies: 'callback' and 'factory'. Either include them or remove the dependency array. If 'callback' changes too often, find the parent component that defines it and wrap that definition in useCallback
|
Account UI:
js/apps/account-ui/test/oid4vci/oid4vci.spec.ts#L7
Unexpected use of the `.skip()` annotation
|
Account UI:
js/apps/account-ui/test/personal-info/personal-info.spec.ts#L70
Unexpected use of page.waitForSelector()
|
Account UI:
js/apps/account-ui/test/personal-info/personal-info.spec.ts#L84
Unexpected use of page.waitForSelector()
|
Admin UI:
js/apps/admin-ui/src/App.tsx#L56
React Hook useEffect has missing dependencies: 'environment' and 'keycloak'. Either include them or remove the dependency array
|
Admin UI:
js/apps/admin-ui/src/authentication/AuthenticationSection.tsx#L102
Hooks must be called at the top level in the body of a function component or custom hook, and may not be called within function expressions. See the Rules of Hooks (https://react.dev/warnings/invalid-hook-call-warning)
|
Admin UI:
js/apps/admin-ui/src/authentication/AuthenticationSection.tsx#L104
Hooks must be the same function on every render, but this value may change over time to a different function. See https://react.dev/reference/rules/react-calls-components-and-hooks#dont-dynamically-use-hooks
|
Admin UI:
js/apps/admin-ui/src/authentication/AuthenticationSection.tsx#L105
Hooks must be the same function on every render, but this value may change over time to a different function. See https://react.dev/reference/rules/react-calls-components-and-hooks#dont-dynamically-use-hooks
|
Admin UI:
js/apps/admin-ui/src/authentication/AuthenticationSection.tsx#L106
Hooks must be the same function on every render, but this value may change over time to a different function. See https://react.dev/reference/rules/react-calls-components-and-hooks#dont-dynamically-use-hooks
|
Admin UI:
js/apps/admin-ui/src/authentication/DuplicateFlowModal.tsx#L45
React Hook useEffect has missing dependencies: 'setValue' and 't'. Either include them or remove the dependency array
|
Admin UI:
js/apps/admin-ui/src/authentication/EditFlowModal.tsx#L31
React Hook useEffect has a missing dependency: 'reset'. Either include it or remove the dependency array
|
Admin UI:
js/apps/admin-ui/src/authentication/components/DraggableTable.tsx#L62
React Hook useMemo has a missing dependency: 'keyField'. Either include it or remove the dependency array
|
Admin UI:
js/apps/admin-ui/src/authentication/components/EditFlow.tsx#L32
React Hook useEffect has a missing dependency: 'form'. Either include it or remove the dependency array
|
Admin UI:
js/apps/admin-ui/src/authentication/components/ExecutionConfigModal.tsx#L110
React Hook useEffect has a missing dependency: 'setupForm'. Either include it or remove the dependency array
|
Account UI E2E
No files were found with the provided path: js/apps/account-ui/playwright-report. No artifacts will be uploaded.
|
🎭 Playwright Run Summary
2 flaky
[chromium] › test/identity-providers/oidc.spec.ts:82:3 › Edit OIDC Provider › should add OIDC mapper of type Attribute Importer
[chromium] › test/user-federation/kerberos.spec.ts:180:5 › User Fed Kerberos tests › Edit Kerberos provider › Should edit existing Kerberos provider and cancel
1 skipped
339 passed (13.1m)
|
Artifacts
Produced during runtime
Name | Size | Digest | |
---|---|---|---|
account-ui-server-log
|
1021 Bytes |
sha256:09842c2f0eef201da3825b644e59827b995ecb6f03924f9d795e4621c741a827
|
|
admin-ui-playwright-report-chromium
Expired
|
3.59 MB |
sha256:800ac740be78ff1a6c79c729c89f0aad53d5d6f5d326e027f27ccd33e1b143e2
|
|
admin-ui-server-log-chromium
|
3.49 KB |
sha256:1a0de40dfafb93c60033ca6fe043cae8ac44526ccf63c9d35fb6a94f92ea35e0
|
|
keycloak
|
148 MB |
sha256:9d95724a04f45bccbc8f305e049baec5362c5e0cf47e00953dffb1a886733bbd
|
|
m2-keycloak.tzts
Expired
|
365 MB |
sha256:c88e7254321074656e1e7f49abdaf071abf69399d0d460ef12a002af855ff2b9
|
|