make group select required when specific group is selected #38768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: keycloak#38767 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
|
@edewit GHA failed for this one, not sure if it's related or not, could you take a look? |
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
|
yeap, fixed it |
vramik
approved these changes
Apr 10, 2025
|
Tested locally and it works fine. |
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Apr 22, 2025
…38768) * make group select required when specific group is selected fixes: keycloak#38767 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * small refactor to make labels not dependant on route Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * fixed tests Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> (cherry picked from commit 514b1b4)
stianst
pushed a commit
that referenced
this pull request
Apr 23, 2025
…39114) * make group select required when specific group is selected fixes: #38767 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * small refactor to make labels not dependant on route Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * fixed tests Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> (cherry picked from commit 514b1b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #38767