8000 BACKPORT:make group select required when specific group is selected (#38768) by edewit · Pull Request #39114 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BACKPORT:make group select required when specific group is selected (#38768) #39114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

BACKPORT:make group select required when specific group is selected (#38768) #39114

merged 1 commit into from
Apr 23, 2025
+38 −44

Conversation

edewit
Copy link
Contributor
@edewit edewit commented Apr 22, 2025 •
edited by stianst
Loading
  • make group select required when specific group is selected

fixes: #38767
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

  • small refactor to make labels not dependant on route

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

  • fixed tests

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com
(cherry picked from commit 514b1b4)

Closes #38767

@edewit
make group select required when specific group is selected (keycloak#…
75f3e6a 
…38768)

* make group select required when specific group is selected

fixes: keycloak#38767
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* small refactor to make labels not dependant on route

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* fixed tests

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 514b1b4)
@edewit edewit requested a review from a team as a code owner April 22, 2025 10:41
stianst
stianst approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor
@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on review in #38768

@stianst stianst merged commit c5513a3 into keycloak:release/26.2 Apr 23, 2025
49 checks passed
@edewit edewit deleted the backport-38768-26.2 branch May 8, 2025 07:56
@stianst stianst mentioned this pull request Jun 3, 2025
Merged
@ryanemerson ryanemerson mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stianst stianst stianst approved these changes

Assignees
No one assigned
Labels
team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edewit @stianst
0