8000 kip-114: Add RANDAO header fields by blukat29 · Pull Request #2009 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

kip-114: Add RANDAO header fields #2009

Merged
merged 10 commits into from
Nov 6, 2023
Merged

kip-114: Add RANDAO header fields #2009

merged 10 commits into from
Nov 6, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Oct 26, 2023 •
edited
Loading

Proposed changes

  • Add header fields randomReveal and mixHash
  • Add predicates ChainConfig.IsRandaoForkEnabled and Rules.IsRandao
  • Following APIs return the new fields:
    • eth_getHeader* eth_getBlock* returns nonzero mixHash after Randao fork (was 0x00..00 before fork)
    • klay_getHeader* klay_getBlock* returns randomReveal and mixHash after Randao fork

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

Future works

  • Istanbul consensus engine processes Randao fields
  • EVM Random opcode
  • Proposer selection based on Randao fields

blukat29 and others added 2 commits October 26, 2023 17:57
@blukat29
Refactor blockchain/types/block_test.go
7c6bc1f 
- Removed Tx encoding tests in favor of TestAbcTransactionEncode
- Removed ancient bcValidBlockTest
- Consolidated block encoding tests
- Explain TestHeaderSizeCalc
@blukat29
Add randomReveal and mixHash header fields
93890ae
@blukat29 blukat29 force-pushed the randao-header-field branch from 61ffad8 to 93890ae Compare October 26, 2023 10:09
@blukat29 blukat29 self-assigned this Oct 27, 2023
hyunsooda
hyunsooda reviewed Oct 27, 2023
View reviewed changes
@blukat29 blukat29 force-pushed the randao-header-field branch from 344ce47 to af0f2da Compare October 27, 2023 09:32
@blukat29 blukat29 marked this pull request as ready for review October 27, 2023 09:47
@blukat29 blukat29 mentioned this pull request Oct 30, 2023
Merged
9 tasks
hyunsooda
hyunsooda reviewed Oct 30, 2023
View reviewed changes
hyunsooda
hyunsooda reviewed Oct 31, 2023
View reviewed changes
hyunsooda
hyunsooda previously approved these changes Nov 1, 2023
View reviewed changes
yoomee1313
yoomee1313 previously approved these changes Nov 1, 2023
View reviewed changes
@blukat29
Copy link
Contributor Author
blukat29 commented Nov 1, 2023

@aidan-kwon @ian0371 PTAL

hyeonLewis
hyeonLewis previously approved these changes Nov 2, 2023
View reviewed changes
ian0371
ian0371 reviewed Nov 2, 2023
View reviewed changes
@blukat29 blukat29 dismissed stale reviews from hyeonLewis, yoomee1313, and hyunsooda via 7d67990 November 2, 2023 04:55
hyeonLewis
hyeonLewis previously approved these changes Nov 2, 2023
View reviewed changes
ian0371
ian0371 previously approved these changes Nov 2, 2023
View reviewed changes
@blukat29 blukat29 dismissed stale reviews from ian0371 and hyeonLewis via c63f468 November 2, 2023 06:37
@blukat29 blukat29 force-pushed the randao-header-field branch from c63f468 to 8654d6f Compare November 2, 2023 06:38
@blukat29
Copy link
Contributor Author
blukat29 commented Nov 2, 2023

Now linter should pass. Sorry for the hassle.

@blukat29 blukat29 merged commit 02e5da6 into klaytn:dev Nov 6, 2023
@blukat29 blukat29 deleted the randao-header-field branch January 4, 2024 05:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyunsooda hyunsooda hyunsooda approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@ian0371 ian0371 ian0371 left review comments

@yoomee1313 yoomee1313 yoomee1313 left review comments

@sjnam sjnam Awaiting requested review from sjnam

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@kjeom kjeom Awaiting requested review from kjeom

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh jeongkyun-oh is a code owner

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blukat29 @ian0371 @hyunsooda @aidan-kwon @yoomee1313 @hyeonLewis
0