10000 kip-114: RANDAO fields processing and EVM random opcode by blukat29 · Pull Request #2014 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

kip-114: RANDAO fields processing and EVM random opcode #2014

Merged
merged 17 commits into from
Nov 15, 2023
Merged

kip-114: RANDAO fields processing and EVM random opcode #2014

merged 17 commits into from
Nov 15, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Oct 30, 2023 •
edited
Loading
  • Load BLS key on CN startup. Auto-derive from ECDSA nodekey.
  • The block proposer uses its BLS key to fill randomReveal and mixHash fields. (CalcRandao)
  • The block validators use the KIP-113 contract to verify the randomReveal and mixHash fields. (VerifyRandao)
  • The EVM RANDAOM (0x44) opcode returns header.MixHash since Randao Hardfork.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

Will be rebased after #2009 merge.

@blukat29 blukat29 self-assigned this Oct 31, 2023
@blukat29 blukat29 changed the title kip-114: Randao block header processing in consensus engine kip-114: RANDAO fields processing and EVM random opcode Nov 1, 2023
@blukat29 blukat29 closed this Nov 6, 2023
@blukat29 blukat29 reopened this Nov 6, 2023
@blukat29 blukat29 force-pushed the randao-consensus branch 5 times, most recently from d012007 to bbfe421 Compare November 7, 2023 01:23
@blukat29 blukat29 force-pushed the randao-consensus branch 2 times, most recently from bc08e9e to 5afeaed Compare November 8, 2023 03:45
@blukat29 blukat29 force-pushed the randao-consensus branch 2 times, most recently from 542319e to 2c48694 Compare November 8, 2023 09:47
@blukat29 blukat29 marked this pull request as ready for review November 8, 2023 10:21
@blukat29
Copy link
Contributor Author
blukat29 commented Nov 9, 2023

Merged in #2024. Checked that opRandom works.

This was referenced Nov 9, 2023
Merged
Merged
Merged
yoomee1313
yoomee1313 reviewed Nov 10, 2023
View reviewed changes
ian0371
ian0371 reviewed Nov 13, 2023
View reviewed changes
ian0371
ian0371 reviewed Nov 13, 2023
View reviewed changes
ian0371
ian0371 reviewed Nov 13, 2023
View reviewed changes
@blukat29
Copy link
Contributor Author

Merged latest dev.

ian0371
ian0371 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor
@ian0371 ian0371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except kcn --bls-nodekey won't work. Please added the flag to nodeflags.go

@blukat29
Copy link
Contributor Author

@ian0371 I will fix that in #2029

@blukat29
Copy link
Contributor Author

@2dvorak @hyunsooda PTAL

2dvorak
2dvorak reviewed Nov 15, 2023
View reviewed changes
hyunsooda
hyunsooda approved these changes Nov 15, 2023
View reviewed changes
@blukat29 blukat29 merged commit 4498e36 into klaytn:dev Nov 15, 2023
@blukat29 blukat29 deleted the randao-consensus branch November 15, 2023 05:06
@blukat29
Copy link
Contributor Author

LGTM except kcn --bls-nodekey won't work. Please added the flag to nodeflags.go

Fixed 734f737.

@blukat29 blukat29 mentioned this pull request Nov 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyunsooda hyunsooda hyunsooda approved these changes

@ian0371 ian0371 ian0371 approved these changes

@2dvorak 2dvorak 2dvorak approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@sjnam sjnam Awaiting requested review from sjnam

@kjeom kjeom Awaiting requested review from kjeom

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blukat29 @ian0371 @hyunsooda @2dvorak @yoomee1313 @hyeonLewis
0