8000 Fix conflicts between v1.12.0 dev and master in advance by blukat29 · Pull Request #2041 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Fix conflicts between v1.12.0 dev and master in advance #2041

Merged
merged 11 commits into from
Nov 21, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Nov 21, 2023

Proposed changes

Fix potential merge conflicts with master in advance 0c82fd6:

  • params/version.go
  • params/config.go

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 self-assigned this Nov 21, 2023
ian0371
ian0371 previously approved these changes Nov 21, 2023
2dvorak
2dvorak previously approved these changes Nov 21, 2023
@blukat29 blukat29 changed the title Prepare merge dev into master for v1.12.0 Fix conflicts between v1.12.0 dev and master in advance Nov 21, 2023
yoomee1313
yoomee1313 previously approved these changes Nov 21, 2023
@blukat29
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@blukat29 blukat29 dismissed stale reviews from yoomee1313, 2dvorak, and ian0371 via 6a08b6d November 21, 2023 02:42
@blukat29 blukat29 requested a review from yoomee1313 November 21, 2023 03:03
@blukat29 blukat29 merged commit 4943f73 into klaytn:dev Nov 21, 2023
@blukat29 blukat29 deleted the v1.12.0-fix-conflict branch January 19, 2024 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0