Fix: do not override uid/git in buildpack builder #2819
Conversation
Zero value implies override (to root presumably), we must set it to negative value. Signed-off-by: Matej Vašek <mvasek@redhat.com>
|
PTAL @lkingland @gauron99 @matzew |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2819 +/- ##
==========================================
+ Coverage 61.58% 62.44% +0.86%
==========================================
Files 131 131
Lines 15793 15796 +3
==========================================
+ Hits 9726 9864 +138
+ Misses 5152 4993 -159
- Partials 915 939 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great, so if I do this it breaks mounts. |
Since we do not override uid/gid==0 we need to make mounted data less readable to all. Signed-off-by: Matej Vašek <mvasek@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.18 |
|
@gauron99: new pull request created: #2822 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Zero value implies override (to root presumably),
we must set it to negative value.
I really dislike that zero value is not neutral here.
fixes: #2516