8000 [release-1.18] Fix: do not override uid/git in buildpack builder by knative-prow-robot · Pull Request #2822 · knative/func · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release-1.18] Fix: do not override uid/git in buildpack builder #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

[release-1.18] Fix: do not override uid/git in buildpack builder #2822

merged 2 commits into from
Apr 30, 2025

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #2819

fix: error "failed to write group file" when using untrusted builder (#2516)

@matejvasek @knative-prow-robot
Fix: do not override uid/git in buildpack builder
b9e85b0 
Zero value implies override (to root presumably),
we must set it to negative value.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek @knative-prow-robot
Fixup tests
f7dc8cc 
Since we do not override uid/gid==0 we need to make mounted data less
readable to all.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Apr 30, 2025
Merged
@knative-prow knative-prow bot requested review from jrangelramos and nainaz April 30, 2025 12:22
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2025
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2025
@knative-prow Knative Prow
Copy link
knative-prow bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
8000

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.44%. Comparing base (4e9fc09) to head (f7dc8cc).
Report is 1 commits behind head on release-1.18.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.18    #2822      +/-   ##
================================================
+ Coverage         61.59%   62.44%   +0.85%     
================================================
  Files               131      131              
  Lines             15794    15796       +2     
================================================
+ Hits               9728     9864     +136     
+ Misses             5155     4993     -162     
- Partials            911      939      +28
Flag Coverage Δ
e2e-test 35.36% <100.00%> (+<0.01%) ⬆️
e2e-test-oncluster 33.81% <100.00%> (+1.41%) ⬆️
e2e-test-oncluster-runtime 28.15% <0.00%> (?)
e2e-test-runtime-go 25.74% <100.00%> (?)
e2e-test-runtime-node 25.10% <100.00%> (?)
e2e-test-runtime-quarkus 25.18% <100.00%> (?)
e2e-test-runtime-rust 24.69% <100.00%> (?)
e2e-test-runtime-springboot 24.73% <100.00%> (?)
e2e-test-runtime-typescript 25.18% <100.00%> (?)
integration-tests 48.60% <100.00%> (+1.82%) ⬆️
unit-tests 48.67% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot merged commit c70d353 into knative:release-1.18 Apr 30, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-prow-robot @matejvasek
0