8000 Remove redundant descriptions from key bindings by scoutgwyndolyn · Pull Request #16220 · luanti-org/luanti · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove redundant descriptions from key bindings #16220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025

Conversation

scoutgwyndolyn
Copy link
Contributor

Goal

Goal: Remove redundant descriptions like "key for moving forward" on the keybind for "Move Forward". Leave important information like "Will also disable autoforward, when active." on keybinds that may need further clarification.
Resolves #16168

To do

Someone should probably look through the settings that were changed and double check, what might be self explanatory to one person might not be to others. Please let me know if you want any of the descriptions added back!
This PR is Ready for Review.

How to test

Build and launch the project.
Check the settings menu and see that the keybinds that are self explanatory have no information string associated with them.
Profit!

@sfan5 sfan5 added the Bugfix 🐛 PRs that fix a bug label Jun 3, 2025
Copy link
Collaborator
@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SmallJoker SmallJoker added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Jun 3, 2025
Copy link
Contributor
@y5nw y5nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. (The comments are largely nitpicks that should not really block.)

keymap_toggle_fog (Toggle fog) key SYSTEM_SCANCODE_60

# Key for toggling the display of debug info.
keymap_toggle_debug (Toggle debug info) key SYSTEM_SCANCODE_62

# Key for toggling the display of the profiler. Used for development.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we can also remove the description for this one since; "toggle profiler" is IMO already clear enough.

Co-authored-by: y5nw <37980625+y5nw@users.noreply.github.com>
@SmallJoker SmallJoker merged commit b9af44b into luanti-org:master Jun 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Key for toggling $FOO" tooltips (and translations)
5 participants
0