8000 Meson updates by tristan957 · Pull Request #1184 · lz4/lz4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Meson updates #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2022
Merged

Meson updates #1184

merged 3 commits into from
Dec 5, 2022

Conversation

tristan957
Copy link
Contributor

No description provided.

@tristan957 tristan957 changed the title Add Meson overrides for the executable and library Add Meson overrides for the library Nov 8, 2022
@tristan957
Copy link
Contributor Author

@Cyan4973 would appreciate a merge on this when you get a chance :)

@tristan957 tristan957 changed the title Add Meson overrides for the library Meson updates Nov 15, 2022
@tristan957
Copy link
Contributor Author

@Cyan4973 @t-mat here are the Meson fixes for freestanding in addition to add a dependency override

@t-mat
Copy link
Contributor
t-mat commented Nov 21, 2022

@tristan957 Looks good. Thanks!
Also as an adaptation of your idea, I'll add test-freestanding to the all of tests/Makefile.

This was referenced Nov 21, 2022
Closed
Merged
@t-mat
Copy link
Contributor
t-mat commented Nov 28, 2022

Sorry for the test failure.
It seems https://github.com/lz4/lz4/actions/runs/3536624577 has successed but https://github.com/lz4/lz4/actions/runs/3542454122 failed.

Since failed tests are unrelated to Meson and we didn't change our .github/ci.yml, I believe it's my mistake, issue from upstream clang or problem in GH-Actions.

@tristan957
Copy link
Contributor Author

@t-mat do you think rebasing on master or rerunning failed jobs would help?

@t-mat
Copy link
Contributor
t-mat commented Nov 28, 2022 •
edited
Loading

Since it doesn't seem random error, it unlikely fixed by the re-running the test.

It seems this error is caused by the changing default behavior of clang-12.

In the our last succeeded test, clang-12 was trying to search gcc/*/11/*
https://github.com/lz4/lz4/actions/runs/3536624577/jobs/5935832118#step:17:291

But in the error log of last commit of this PR, clang-12 has failed to find library in gcc/*/12/*.
https://github.com/lz4/lz4/actions/runs/3542454122/jobs/5947968452#step:17:293

Therefore, it seems clang-12 has changed their search path from lib*32gcc-11-dev to lib*32gcc-12-dev by the unknown reason.

edit : In these two tests, there's no version difference of clang and multilib. Anyway, changing version of multilib may fix this issue.

@tristan957
Copy link
Contributor Author

@t-mat while I have you, do you think this PR can be merged?

@t-mat
Copy link
Contributor
t-mat commented Nov 29, 2022

@tristan957 I think the shape of this PR itself is good. But since test for this PR has failed, we must fix it to ease reviewing process.

I have to go out for now. So I'll begin to fix this GitHub Actions issue in 10 to 12 hours later. Again, I'm really sorry for the inconvenience which is caused by my mistake.

@tristan957
Copy link
Contributor Author
tristan957 commented Nov 29, 2022 •
edited
Loading

Not a big deal though this PR doesn't touch anything related to the test failure since I only touch meson.build files and the failing jobs use the Makefile based build.

This was referenced Nov 29, 2022
Closed
Merged
@Cyan4973
Copy link
Member
Cyan4973 commented Dec 3, 2022

Hi @tristan957

I noticed you pushed an update 1 hour ago,

In your opinion, is this PR completed, or do you still intend to work and update it ?

@tristan957
Copy link
Contributor Author

It is completed. I pushed to consume the CI fix from @t-mat

t-mat added a commit to t-mat/lz4 that referenced this pull request Dec 3, 2022
@t-mat
Add "freestanding" to "all" and "test" of tests/Makefile
59578be 
Follow up of lz4#1184 and lz4#1187

Now `tests/Makefile` contains

- `freestanding` as a member of `all`.
- `test-freestanding` as a member of `test`.

Note that as for `all32` (`-m32`) builds, `test-freestanding` skips its actual test.
@t-mat t-mat mentioned this pull request Dec 3, 2022
Closed
t-mat added a commit to t-mat/lz4 that referenced this pull request Dec 3, 2022
@t-mat
Add "freestanding" to "all" and "test" of tests/Makefile
95d7c29 
Follow up of lz4#1184 and lz4#1187

Now `tests/Makefile` contains

- `freestanding` as a member of `all`.
- `test-freestanding` as a member of `test`.

Note that as for `all32` (`-m32`) builds, `test-freestanding` skips its actual test.
@Cyan4973 Cyan4973 merged commit 299daf0 into lz4:dev Dec 5, 2022
@tristan957 tristan957 deleted the meson branch December 5, 2022 16:28
@tristan957
Copy link
Contributor Author

@Cyan4973 @t-mat I appreciate your help in this PR :)

@moonfruit moonfruit mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristan957 @t-mat @Cyan4973
0