8000 Change the version of lib[x]gcc for clang-(11|12) -mx32 by t-mat · Pull Request #1197 · lz4/lz4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change the version of lib[x]gcc for clang-(11|12) -mx32 #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

Change the version of lib[x]gcc for clang-(11|12) -mx32 #1197

merged 1 commit into from
Nov 29, 2022

Conversation

t-mat
Copy link
Contributor
@t-mat t-mat commented Nov 29, 2022

This PR fixes some failures of test for clang-(11|12) -mx32.

Full test log : https://github.com/t-mat/lz4/actions/runs/3574889011/jobs/6010732105

Please refer the following comments for details

@t-mat
Copy link
Contributor Author
t-mat commented Nov 29, 2022

Note : When this PR will land, #1184 needs re-running of GitHub Actions.

@Cyan4973
Copy link
Member

This change from lib*gcc-11 to lib*gcc-12 feels weird ....
This test has been working fine so far !

@t-mat
Copy link
Contributor Author
t-mat commented Nov 29, 2022

This change from lib*gcc-11 to lib*gcc-12 feels weird .... This test has been working fine so far !

Yeah, definitely I agree with you. And I still don't understand why newer clangs are working without tweaking 😮
But, anyway, I'd like to leave them for now. Because I still don't have any idea what causes this sudden change/errors.

@Cyan4973 Cyan4973 merged commit 8f2fad8 into lz4:dev Nov 29, 2022
@t-mat t-mat deleted the fix-test-clang-11-12-mx32 branch November 29, 2022 17:37
@moonfruit moonfruit mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-mat @Cyan4973
0