Duplicate code cleanup in Tiled Map Loaders. Replacement for PR(#7136) #7635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Loader to reflect PR libgdx#7136's code duplication fix. Did the same for the TmjMapLoader as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for the original one from back in 2023.
The original PR was no longer easily mergeable as the Map Loaders have been changed around a bit since then. But the core code he was trying to optimize still existed, it was just shifted around into a newly added getTileSetDependencyFileHandle method.
I also went ahead and modified the code in the new TmjMapLoader to match as both map loader's shared a similar structure So we got a 2 for 1 clean up deal here.
Other than that there isn't much else to this PR. So this is it, the last of the 2 fixable PRs on the big list. #7488