8000 SP Registry distributeRewards with share-based stETH token · Issue #72 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SP Registry distributeRewards with share-based stETH token #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ongrid opened this issue Oct 18, 2020 · 0 comments · Fixed by #76
Closed

SP Registry distributeRewards with share-based stETH token #72

ongrid opened this issue Oct 18, 2020 · 0 comments · Fixed by #76
Assignees
@lxzrv
Labels
bug Something isn't working

Comments

@ongrid
Copy link
Contributor
ongrid commented Oct 18, 2020 •
edited
Loading

Base branch: steth_depool_linked

Integration tests with stETH fail on the line:

https://github.com/depools/depool-dao/blob/16820516a8e481e660f5dd106d150c7ff7b8866c/contracts/0.4.24/sps/StakingProvidersRegistry.sol#L312

Also noted that some transfers on this line were called with zero amount, that shouldn't be done.

This can affect depool.test.js:381 (reverts, commented-out)

Need to unmute treasury, insurance and SP balance assertions in depool.test.js:117 to 121
@ongrid ongrid added the bug Something isn't working label Oct 18, 2020
lxzrv pushed a commit that referenced this issue Oct 19, 2020
Fix #72
50da3cc
lxzrv pushed a commit that referenced this issue Oct 20, 2020
Fix #72
c53ba2d
@lxzrv lxzrv mentioned this issue Oct 20, 2020
Merged
lxzrv pushed a commit that referenced this issue Oct 20, 2020
Fix steth rewards test #72
9f755db
@ongrid ongrid mentioned this issue Oct 20, 2020
Closed
lxzrv pushed a commit that referenced this issue Oct 20, 2020
Fix steth rewards test #72
eb2f524
ongrid pushed a commit that referenced this issue Oct 21, 2020
@ongrid
Fix #72
6d7ef41
ongrid pushed a commit that referenced this issue Oct 21, 2020
@ongrid
Fix steth rewards test #72
73725de
@ongrid ongrid linked a pull request Oct 21, 2020 that will close this issue
Steth fix rewards #76
Merged
@ongrid ongrid closed this as completed Oct 22, 2020
ongrid pushed a commit that referenced this issue Oct 22, 2020
@ongrid
Fix #72
fb7633b
ongrid pushed a commit that referenced this issue Oct 22, 2020
@ongrid
Fix steth rewards test #72
1c58557
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@ongrid
Fix lidofinance#72
ca2b5bd
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@ongrid
Fix steth rewards test lidofinance#72
01ac59e
tamtamchik pushed a commit that referenced this issue Sep 30, 2024
@failingtwice
Merge pull request #72 from lidofinance/develop
f992de8 
Weekly PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lxzrv lxzrv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Steth fix rewards lidofinance/core
2 participants
@ongrid @lxzrv
0