8000 Backlog for RC-1 milestone · Issue #77 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backlog for RC-1 milestone #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ongrid opened this issue Oct 20, 2020 · 0 comments
Closed

Backlog for RC-1 milestone #77

ongrid opened this issue Oct 20, 2020 · 0 comments
Assignees
@ongrid
Labels
documentation Improvements or additions to documentation
Milestone
RC1

Comments

@ongrid
Copy link
Contributor
ongrid commented Oct 20, 2020 •
edited by skozin
Loading

The following table summarizes the list of DePool contracts, docs and test improvements for RC-1 release candidate. RC1 plans are confirmed on the zoom call 20 Oct 2020.

For RC-2 see #94

Table maintained by @ongrid. Please feel free to drop your ideas in comments (for discussion) or create the issue with assigned RC milestone if you are able to finally formalize the scope.

Short Description and GH issue Where Type Milestone, status, assignee Details
SP Registry distributeRewards fails with stETH token #72 done stETH Integration RC-1 @lxzrv @ongrid Integration tests fail on reward distribution
Fix muted tests in steth_depool_linked #73 done DePool, stETH Tests RC-1 @lxzrv @ongrid Fix muted assertions and setups in integration tests: depool_happy_path.js:301-308 depool.test.js - lines highlighted with //FixMe
Withdraw explanation wait DePool Doc RC-1 @vshvsh withdraw function has unclear state - ToDo. Since it occludes the key business logic - it will be in the main people focus, so its docstring should describe in detail about future implementation and migration. When and how it will be implemented, how migration to the contract with implemented withdraw will be carried out. It must be the most documented function in the entire codebase.
Fix solc, solium and solhint warnings #84 done DePool, Oracle, stETH, cStETH + child libs and interfaces Unify RC-1 @ongrid @lxzrv Fix solhint warnings and stilyze the contract codebase in a single manner including existing comments. Fix compiler warnings. Solc stdout should be clean.
Docstrings #87 wip DePool, Oracle, stETH Doc, Unify RC-1 @ongrid All the libraries, contracts and functions should have relevant DoxygenStrings. Docs should follow the same style, describing the interface and purpose. Non-trivial math should be explained in detail. If the code was inherited or inspired, should provide the link to the source.
Solc motivation #86 done DePool, Oracle, stETH, cstETH Doc RC-1 @ongrid Comment above pragma statement should clearly explain why solidity 0.4.24 or 0.6.x selected for specific contract.
ACL roles done DePool, Oracle, stETH Doc RC-1 @skozin Describe each ACL role and where it's used
Positions done DePool, Oracle, stETH Doc RC-1 @skozin describe why POSITIONs used instead of traditional variables
reportEther2 RBAC #85 wip DePool, Oracle, stETH Unify RC-1 @ongrid @Klyaus DePool.sol:reportEther2 - use Aragon's approach with role modifier instead of require check
JavaScript code style #19 done Tests, Frontend Tests RC-1 @krogla or @skozin ? Currently, multiple different styles are mixed within even a single test file. This makes it harder to read and write the code.
IDepositContract #88 done DePool Unify RC-2 @Klyaus use original Ethereum 2 IDepositContract instead of IValidatorRegistration for simplicity and uniform terminology.

Other 16 items were moved to Backlog for RC-2 milestone #94
@ongrid ongrid self-assigned this Oct 20, 2020
@ongrid ongrid added the documentation Improvements or additions to documentation label Oct 20, 2020
@ongrid ongrid added this to the RC1 milestone Oct 20, 2020
@ongrid ongrid pinned this issue Oct 22, 2020
@ongrid ongrid changed the title Backlog for RC-1 and RC-2 milestones Backlog for RC-1 milestone Oct 27, 2020
@ongrid ongrid mentioned this issue Oct 27, 2020
Closed
@ongrid ongrid closed this as completed Oct 28, 2020
@ongrid ongrid unpinned this issue Nov 10, 2020
tamtamchik added a commit that referenced this issue Sep 30, 2024
@tamtamchik
Merge pull request #77 from lidofinance/feat/poetry-update
3cfde59 
chore: update poetry dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ongrid ongrid

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
RC1
Development

No branches or pull requests
1 participant
@ongrid
0