8000 reportEther2 switch to Aragon's access-control role modifier · Issue #85 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

reportEther2 switch to Aragon's access-control role modifier #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ongrid opened this issue Oct 22, 2020 · 1 comment
Closed

reportEther2 switch to Aragon's access-control role modifier #85

ongrid opened this issue Oct 22, 2020 · 1 comment
Assignees
@ongrid
Milestone
RC3

Comments

@ongrid
Copy link
Contributor
ongrid commented Oct 22, 2020

function reportEther2(uint256 _epoch, uint256 _eth2balance) uses in-block check of the caller:
require(msg.sender == getOracle(), "APP_AUTH_FAILED"). For RBAC it's correct to use Aragon's auth modifier. Examples: setWithdrawalCredentials and setDepositIterationLimit.

Effects stay the same.
@ongrid ongrid assigned lxzrv and Klyaus and unassigned lxzrv Oct 22, 2020
@ongrid ongrid mentioned this issue Oct 22, 2020
Closed
@ongrid ongrid added this to the RC1 milestone Oct 22, 2020
@Klyaus Klyaus assigned ongrid and unassigned Klyaus Oct 23, 2020
@ongrid ongrid mentioned this issue Oct 27, 2020
Closed
@ongrid ongrid modified the milestones: RC1, RC2, RC-3 Oct 28, 2020
@ongrid
Copy link
Contributor Author
ongrid commented Jan 12, 2021

This had been never highlighted as a flaw or best practice deviation. The issue can be closed.

@ongrid ongrid closed this as completed Jan 12, 2021
tamtamchik pushed a commit that referenced this issue Sep 30, 2024
@failingtwice
Merge pull request #85 from lidofinance/feat/yarn
d8ea7c3 
chore: move to yarn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ongrid ongrid

Labels
None yet
Projects
None yet
Milestone
RC3
Development

No branches or pull requests
3 participants
@ongrid @Klyaus @lxzrv
0