8000 Fix solc, solium and solhint warnings · Issue #84 · lidofinance/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix solc, solium and solhint warnings #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ongrid opened this issue Oct 22, 2020 · 0 comments · Fixed by #90
Closed

Fix solc, solium and solhint warnings #84

ongrid opened this issue Oct 22, 2020 · 0 comments · Fixed by #90
Assignees
@lxzrv
Milestone
RC1

Comments

@ongrid
Copy link
Contributor
ongrid commented Oct 22, 2020

Fix function-order, indentation, blank-lines and line-length in solidity files. Keep comments and docstrings intact (they will be the subject of separate issue).

Styling references:

@aragon/os/contracts/apps/AragonApp.sol
@aragon/os/contracts/lib/math/SafeMath.sol
@openzeppelin-solidity/contracts/token/ERC20/ERC20.sol
  • Add relevant configs for solium and solhint.
  • Add solhint to package.json lint script (should run both)
  • mute compile-time SPDX-License-Identifier warning (retaled to our code)
@ongrid ongrid mentioned this issue Oct 22, 2020
Closed
@ongrid ongrid added this to the RC1 milestone Oct 22, 2020
lxzrv pushed a commit that referenced this issue Oct 22, 2020
Use aragon solium config, refactor accordingly #84
ff7e058
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Apply linters #84
60ac1f6
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Update package.json scripts #84
b51e901
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Apply js linter autofix #84
7e1acf0
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix package.json scripts, fix .eslintrc #84
72d9bfb
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix all js linter warnings #84
aa75613
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix solhint warnings #84
47951b4
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix solhint warnings #84
0733c92
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Use aragon solium config, refactor accordingly #84
85ba1dc
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Apply linters #84
a554e28
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Update package.json scripts #84
b401467 8000
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix package.json scripts, fix .eslintrc #84
0dd3dc9
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix all js linter warnings #84
323a477
lxzrv pushed a commit that referenced this issue Oct 23, 2020
Fix solhint warnings #84
6c491a6
@lxzrv lxzrv mentioned this issue Oct 23, 2020
Merged
lxzrv pushed a commit that referenced this issue Oct 26, 2020
Use aragon solium config, refactor accordingly #84
0066925
lxzrv pushed a commit that referenced this issue Oct 26, 2020
Apply linters #84
4c0d2e4
lxzrv pushed a commit that referenced this issue Oct 26, 2020
Update package.json scripts #84
9d142f0
lxzrv pushed a commit that referenced this issue Oct 26, 2020
Fix package.json scripts, fix .eslintrc #84
a986791
lxzrv pushed a commit that referenced this issue Oct 26, 2020
Fix all js linter warnings #84
67f650f
lxzrv pushed a commit that referenced this issue Oct 26, 2020
Fix solhint warnings #84
ad2162e
@lxzrv lxzrv closed this as completed in #90 Oct 26, 2020
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Use aragon solium config, refactor accordingly lidofinance#84
6261eea
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Apply linters lidofinance#84
17a2256
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Update package.json scripts lidofinance#84
8671e14
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Fix package.json scripts, fix .eslintrc lidofinance#84
c9fae1c
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Fix all js linter warnings lidofinance#84
3a3937d
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Fix solhint warnings lidofinance#84
17e4b6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lxzrv lxzrv

Labels
None yet
Projects
None yet
3C7A Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Linters lidofinance/core
2 participants
@ongrid @lxzrv
0