-
Notifications
You must be signed in to change notification settings - Fork 169
chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload #715
Conversation
Bumps [multer](https://github.com/expressjs/multer) from 1.4.5-lts.1 to 2.0.0. - [Release notes](https://github.com/expressjs/multer/releases) - [Changelog](https://github.com/expressjs/multer/blob/v2.0.0/CHANGELOG.md) - [Commits](expressjs/multer@v1.4.5-lts.1...v2.0.0) --- updated-dependencies: - dependency-name: multer dependency-version: 2.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to multer@2
is fine, but leaving @types/multer@1.x
creates a high risk of type conflicts or hiding API breaks. Additionally, communicating the new Node runtime requirement via an engines
field would improve developer experience.
Additional notes (1)
- Maintainability |
examples/nextjs-file-upload/package.json:6-7
multer@2
raises the minimum supported Node version to 10.16.0. While this is not an issue for modern environments, it is a breaking change. Adding anengines
field helps downstream consumers detect an unsupported runtime early.
Summary of changes
What changed
- package.json (example app)
- Upgraded
multer
from^1.4.5-lts.1
➜^2.0.0
- Upgraded
@@ -6,7 +6,7 @@ | |||
"start": "next start" | |||
}, | |||
"dependencies": { | |||
"multer": "^1.4.5-lts.1", | |||
"multer": "^2.0.0", | |||
"next": "^14.2.15", | |||
"node-fetch": "^3.3.2", | |||
"react": "^18.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multer@2
bundles several breaking changes and now ships its own TypeScript declarations. Keeping @types/multer
on the old 1.x
line can:
- Introduce duplicate / conflicting type definitions at compile time.
- Mask API breaks introduced in v2 because the older typings still reflect the v1 surface area.
Consider removing the extra typings (preferred) or upgrading them to the matching major version if DefinitelyTyped publishes a 2.x
package.
Suggestion
"devDependencies": {
- "@types/multer": "^1.4.7",
+ "@types/multer": "^2.0.0"
"@types/node": "20.4.2",
"@types/node-fetch": "^2.6.4"
}
If the multer
package now provides its own types you can instead delete the line entirely.
Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this suggestion.
Bumps multer from 1.4.5-lts.1 to 2.0.0.
Release notes
Sourced from multer's releases.
Changelog
Sourced from multer's changelog.
Commits
2c8505f
🐛 drain stream. fixes regression in node 18, remove old CI, set minimum node ...bde1822
ci: add ci pipeline tolts
branch (#1302)8ec534f
version: 1.4.5-lts.2502c03d
history: 1.4.5-lts.24ce82b0
test: add test for out-of-band error eventa4be1d5
Merge pull request #1177 from max-mathieu/fix/unhandled-busboy-error37241f8
Fix out-of-band error event from busboyMaintainer changes
This version was pushed to npm by ulisesgascon, a new releaser for multer since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.