8000 chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload by dependabot[bot] · Pull Request #715 · linear/linear · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor
@dependabot dependabot bot commented on behalf of github May 20, 2025

Bumps multer from 1.4.5-lts.1 to 2.0.0.

Release notes

Sourced from multer's releases.

v2.0.0

Important

What's Changed

  • 🐛 drain stream. fixes regression in node 18, remove old CI, set minimum node version, fix readme badges, add .npmrc
  • fix: handle two busboy error events
  • ♻️ fully drain stream
  • 🥅 explicitly handle req error
  • 🚨 lint:fix
  • ⬆️ bump mocha
  • docs: include release 2.0.0 details
Changelog

Sourced from multer's changelog.

2.0.0

1.4.5-lts.2

  • Fix out-of-band error event from busboy (#1177)
Commits
  • 2c8505f 🐛 drain stream. fixes regression in node 18, remove old CI, set minimum node ...
  • bde1822 ci: add ci pipeline to lts branch (#1302)
  • 8ec534f version: 1.4.5-lts.2
  • 502c03d history: 1.4.5-lts.2
  • 4ce82b0 test: add test for out-of-band error event
  • a4be1d5 Merge pull request #1177 from max-mathieu/fix/unhandled-busboy-error
  • 37241f8 Fix out-of-band error event from busboy
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by ulisesgascon, a new releaser for multer since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [multer](https://github.com/expressjs/multer) from 1.4.5-lts.1 to 2.0.0.
- [Release notes](https://github.com/expressjs/multer/releases)
- [Changelog](https://github.com/expressjs/multer/blob/v2.0.0/CHANGELOG.md)
- [Commits](expressjs/multer@v1.4.5-lts.1...v2.0.0)

---
updated-dependencies:
- dependency-name: multer
  dependency-version: 2.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 20, 2025
@charliecreates charliecreates bot requested a review from CharlieHelps May 20, 2025 01:45
Copy link
changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 3991a17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
@charliecreates charliecreates bot left a comment
< 8000 /a>

Upgrading to multer@2 is fine, but leaving @types/multer@1.x creates a high risk of type conflicts or hiding API breaks. Additionally, communicating the new Node runtime requirement via an engines field would improve developer experience.

Additional notes (1)
  • Maintainability | examples/nextjs-file-upload/package.json:6-7
    multer@2 raises the minimum supported Node version to 10.16.0. While this is not an issue for modern environments, it is a breaking change. Adding an engines field helps downstream consumers detect an unsupported runtime early.
Summary of changes

What changed

  • package.json (example app)
    • Upgraded multer from ^1.4.5-lts.1^2.0.0

@@ -6,7 +6,7 @@
"start": "next start"
},
"dependencies": {
"multer": "^1.4.5-lts.1",
"multer": "^2.0.0",
"next": "^14.2.15",
"node-fetch": "^3.3.2",
"react": "^18.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multer@2 bundles several breaking changes and now ships its own TypeScript declarations. Keeping @types/multer on the old 1.x line can:

  1. Introduce duplicate / conflicting type definitions at compile time.
  2. Mask API breaks introduced in v2 because the older typings still reflect the v1 surface area.

Consider removing the extra typings (preferred) or upgrading them to the matching major version if DefinitelyTyped publishes a 2.x package.

Suggestion
  "devDependencies": {
-   "@types/multer": "^1.4.7",
+   "@types/multer": "^2.0.0"
    "@types/node": "20.4.2",
    "@types/node-fetch": "^2.6.4"
  }

If the multer package now provides its own types you can instead delete the line entirely.

Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this suggestion.

@charliecreates charliecreates bot removed the request for review from CharlieHelps May 20, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants
0