8000 chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload by dependabot[bot] · Pull Request #715 · linear/linear · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0 in /examples/nextjs-file-upload #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/nextjs-file-upload/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"start": "next start"
},
"dependencies": {
"multer": "^1.4.5-lts.1",
"multer": "^2.0.0",
"next": "^14.2.15",
"node-fetch": "^3.3.2",
"react": "^18.2.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multer@2 bundles several breaking changes and now ships its own TypeScript declarations. Keeping @types/multer on the old 1.x line can:

  1. Introduce duplicate / conflicting type definitions at compile time.
  2. Mask API breaks introduced in v2 because the older typings still reflect the v1 surface area.

Consider removing the extra typings (preferred) or upgrading them to the matching major version if DefinitelyTyped publishes a 2.x package.

Suggestion 
  "devDependencies": {
-   "@types/multer": "^1.4.7",
+   "@types/multer": "^2.0.0"
    "@types/node": "20.4.2",
    "@types/node-fetch": "^2.6.4"
  }

If the multer package now provides its own types you can instead delete the line entirely.

Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this suggestion.

Expand Down
8 changes: 4 additions & 4 deletions examples/nextjs-file-upload/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,10 @@ mkdirp@^0.5.4:
dependencies:
minimist "^1.2.6"

multer@^1.4.5-lts.1:
version "1.4.5-lts.1"
resolved "https://registry.yarnpkg.com/multer/-/multer-1.4.5-lts.1.tgz#803e24ad1984f58edffbc79f56e305aec5cfd1ac"
integrity sha512-ywPWvcDMeH+z9gQq5qYHCCy+ethsk4goepZ45GLD63fOu0YcNecQxi64nDs3qluZB+murG3/D4dJ7+dGctcCQQ==
multer@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/multer/-/multer-2.0.0.tgz#47076aa0f7c2c2fd273715e767c6962bf7f94326"
integrity sha512-bS8rPZurbAuHGAnApbM9d4h1wSoYqrOqkE+6a64KLMK9yWU7gJXBDDVklKQ3TPi9DRb85cRs6yXaC0+cjxRtRg==
dependencies:
append-field "^1.0.0"
busboy "^1.0.0"
Expand Down
0