8000 [FIRRTL] Tweak naming by darthscsi · Pull Request #5288 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FIRRTL] Tweak naming #5288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2023
Merged

[FIRRTL] Tweak naming #5288

merged 5 commits into from
May 30, 2023

Conversation

darthscsi
Copy link
Contributor

Lots of T and WIRE were appearing in the output. These are quite useless. We filter these out at all name preservation levels. This also allows putting other names which start with '' as droppable.

Also reorder a pass to increase parallelism [NFCI]

@darthscsi
[FIRRTL] Tweak naming
dbc5f68 
Lots of _T_ and _WIRE were appearing in the output.  These are quite useless.  We filter these out at all name preservation levels.  This also allows putting other names which start with '_' as droppable.
@darthscsi darthscsi requested review from mikeurbach and uenoku May 27, 2023 01:40
@darthscsi
Copy link
Contributor Author

@mikeurbach , @uenoku I think this might filter out a lot of the truely useless names which are making it to the output, without harming much else. I was seeing lots of T coming out of firtool. This seems to clean it up. Hopefully should improve CSE for resets on verif constructs.

uenoku
uenoku reviewed May 29, 2023
View reviewed changes
uenoku
uenoku reviewed May 29, 2023
View reviewed changes
uenoku
uenoku approved these changes May 29, 2023
View reviewed changes
Copy link
Member
@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

LGTM

@darthscsi darthscsi merged commit 884e360 into main May 30, 2023
@uenoku uenoku mentioned this pull request Jun 12, 2023
Closed
@darthscsi darthscsi deleted the dev/darthscsi/nametweak branch April 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
69E2 Reviewers

@uenoku uenoku uenoku approved these changes

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

@mikeurbach mikeurbach Awaiting requested review from mikeurbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darthscsi @uenoku
0