8000 Some updates to image module by ankith26 · Pull Request #2226 · pygame/pygame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Some updates to image module #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our ter 8000 ms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Some updates to image module #2226

wants to merge 6 commits into from

Conversation

ankith26
Copy link
Contributor

Just some updates to image module. Working on #1732, and some other minor changes

MightyJosip
MightyJosip suggested changes Oct 22, 2020
View reviewed changes
src_c/image.c
8000
static PyObject *extverobj = NULL;

/* define docs for undocumented (kinda deprecated) functions */
#define DOC_PYGAMEIMAGELOADBASIC "internal function to load images, use pygame.image.load() instead of this"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docstrings should be in this file: https://github.com/pygame/pygame/blob/master/src_c/doc/image_doc.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but these are temporary-undocumented functions, they cannot go in that file right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus those files are auto generated from the rest files, I guess they will dissapear the next time, those files get generated.

@illume illume closed this Oct 27, 2020
@illume illume deleted the branch master October 27, 2020 16:15
@illume illume mentioned this pull request Oct 27, 2020
Closed
illume pushed a commit that referenced this pull request Nov 28, 2020
Documented pygame.image load_basic, load_extended, save_extended. ima…
0e98ce5 
…ge.c code cleanups. (#2270)

fixes #1732
image.c code cleanups, and CPython API usage fixes.

Continued on from #2226 PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MightyJosip MightyJosip MightyJosip requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankith26 @MightyJosip @illume
0