-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Documented pygame.image load_basic, load_extended, save_extended. image.c code cleanups. #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, can you please add a description of what this PR is for? Is it ready to review? cheers, |
Well, this PR is basically code cleanup, but is also closing #1732 and making the function doc-strings more accurate. It’s been ready for code review since the last commit |
I documented the functions, so that this PR is ready to merge. PS: I would like if this PR gets squash-merged, just the because I don’t want my messy commits lingering around in pygame commit-history :) |
Oops, I forgot [skip ci] on this one. It was merely a docs change. |
Ok, cool.
We're not currently testing docs, but that would be a nice optimization to skip jobs based on paths changed. Maybe some new new stuff allows that now. |
Looking good, thanks :) The code is much easier to read now. I updated the title, and PR description so it can be used in the commit message. Even though there are no new tests in the PR... The functions changed are already quite well tested :) Testing save_extended with the missing SDL2_image is possible, but quite hard since we're not already testing that configuration in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Documented pygame.image load_basic, load_extended, save_extended
Continued on from #2226 PR.