8000 Documented pygame.image load_basic, load_extended, save_extended. image.c code cleanups. by ankith26 · Pull Request #2270 · pygame/pygame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Documented pygame.image load_basic, load_extended, save_extended. image.c code cleanups. #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 28, 2020

Conversation

ankith26
Copy link
Contributor
@ankith26 ankith26 commented Oct 29, 2020

Documented pygame.image load_basic, load_extended, save_extended

Continued on from #2226 PR.

@illume
Copy link
Member
illume commented Nov 7, 2020

Hi,

can you please add a description of what this PR is for? Is it ready to review?
It looks like a code cleanup?

cheers,

@ankith26
Copy link
Contributor Author
ankith26 commented Nov 7, 2020

Well, this PR is basically code cleanup, but is also closing #1732 and making the function doc-strings more accurate. It’s been ready for code review since the last commit

@ankith26
Copy link
Contributor Author
ankith26 commented Nov 27, 2020

I documented the functions, so that this PR is ready to merge.

PS: I would like if this PR gets squash-merged, just the because I don’t want my messy commits lingering around in pygame commit-history :)
Anyways, either way is fine

@ankith26
Copy link
Contributor Author

Oops, I forgot [skip ci] on this one. It was merely a docs change.
Sorry

@illume
Copy link
Member
illume commented Nov 28, 2020

I documented the functions, so that this PR is ready to merge.
PS: I would like if this PR gets squash-merged, just the because I don’t want my messy commits lingering around in pygame commit-history :)

Ok, cool.

Oops, I forgot [skip ci] on this one. It was merely a docs change.

We're not currently testing docs, but that would be a nice optimization to skip jobs based on paths changed. Maybe some new new stuff allows that now.

@illume illume changed the title Some updates to the image module Documented pygame.image load_basic, load_extended, save_extended. image.c code cleanups. Nov 28, 2020
@illume illume added docs image pygame.image labels Nov 28, 2020
@illume
Copy link
Member
illume commented Nov 28, 2020

Looking good, thanks :) The code is much easier to read now.

I updated the title, and PR description so it can be used in the commit message.

Even though there are no new tests in the PR... The functions changed are already quite well tested :) Testing save_extended with the missing SDL2_image is possible, but quite hard since we're not already testing that configuration in CI.

Copy link
Member
@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illume illume merged commit 0e98ce5 into main Nov 28, 2020
@illume illume deleted the ankith26-patch-1 branch November 28, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4FE6
Labels
docs image pygame.image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pygame.image docs missing functions and load_basic ignore namehint argument
2 participants
0