minimal upgrade to PyO3 0.23 (ignoring deprecations) #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1556 will degrade performances by 16.85%Comparing Summary
Benchmarks breakdown
|
|
Perf regressions are only part of the varied story; some of the benches showing up to 12% improvement. Overall in PyO3 0.23 because of the freethreading changes as well as In summary I am not super worried about the regressions, they probably are due to the |
samuelcolvin
approved these changes
Nov 26, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This updates PyO3 to 0.23. To keep things reviewable, I have started here by ignoring deprecations and just fixing the immediate build failures caused by the version bump.
They fit mostly into two categories:
IntoPyObjectand changed many methods to use it instead ofIntoPy<PyObject>andToPyObject. This PR tries to avoid switching traits as much as possible, making the changes only where necessary to fix compile failures.#[pyclass]types to beSync(i.e. thread-safe), so I had to replaceRefCellwith aMutexin a couple of internal places.Needs
jiterrelease pushed before this can be merged.Related issue number
Related to #1555
Checklist
pydantic-core(except for expected changes)