clean up deprecations in PyO3 0.23 for tests / benches #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1575 will not alter performanceComparing Summary
|
davidhewitt
commented
Dec 9, 2024
| #[cfg(test)] | ||
| mod tests { | ||
| use _pydantic_core::{SchemaSerializer, SchemaValidator, WarningsArg}; | ||
| use pyo3::ffi::c_str; // can switch to c"" literals on MSRV >= 1.77 |
There was a problem hiding this comment.
Benchmarks currently run on nightly rust so can use c"" immediately.
sydney-runkle
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Followup to #1556. This PR updates the rust benchmarks and tests, the main lib is a bigger job and will come separately.
The changes stem from two main sources:
py.run_boundin favour of newpy.run, sometimes these take&CStrinstead of&strwhen the underlying Python API wants a null-terminated string..to_object(py)and.into_py(py)with.into_pyobject(py), which has some benefits and simplifications though is always fallible so requires some adjusting for error handling.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)