8000 [BUGFIX] ListVariable: fix autocomplete when 'All' is selected by Gladorme · Pull Request #2554 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] ListVariable: fix autocomplete when 'All' is selected #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Gladorme
Copy link
Member
@Gladorme Gladorme commented Jan 14, 2025

Description

Close #2277. Found other issue when testing the fix: dropdown position changing when removing change from All to an item

Screenshots

output

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Sorry, something went wrong.

@Gladorme Gladorme force-pushed the gladorme/fix-all-autocomplete branch from d5c491e to f453cba Compare January 14, 2025 16:01
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme force-pushed the gladorme/fix-all-autocomplete branch from f453cba to 7ea06ad Compare January 14, 2025 16:02
@Gladorme Gladorme marked this pull request as ready for review January 14, 2025 16:08
Copy link
Contributor
@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on that one 🚀

@Gladorme Gladorme added this pull request to the merge queue Jan 15, 2025
Merged via the queue into perses:main with commit c19e71d Jan 15, 2025
18 checks passed
@Gladorme Gladorme deleted the gladorme/fix-all-autocomplete branch January 15, 2025 08:47
Nexucis pushed a commit that referenced this pull request Jan 23, 2025
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Nexucis added a commit that referenced this pull request Jan 23, 2025
* [BUGFIX] ListVariable: fix autocomplete when 'All' is selected (#2554)

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [IGNORE] Add error boundary around recent dashboard on home page (#2560)

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [FEATURE] Value mapping settings for Status History and Stat Chart (#2462)

* Status History

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* add value mapping to stat chart

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* add tests

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* update migration

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix cue format

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix types

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix mapping priority

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix zero value mapping

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* revert box styles

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* Update ui/components/src/StatChart/StatChart.tsx

Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix threshold condition

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix test

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* update mui grid

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix lint

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* fix

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* add stat chart value mapping migration and test

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* update regex value mapping

Signed-off-by: Alexander Belya
8000
kin <21216343+abelyakin@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* add support to greater then and less then to range

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

---------

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>
Co-authored-by: Belyakin Aleksandr Andreevich <belyakinaa@cloudx.group>
Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [BUGFIX] Login from percli (method not allowed) (#2577)

* [BUGFIX] Login from percli (method not allowed)

Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>

* move urlutils method to pkg/api/v1/common

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

---------

Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Co-authored-by: Augustin Husson <husson.augustin@gmail.com>

* [BUGFIX] Inject API prefix in all UI assets (#2576)

* [BUGFIX] Inject API prefix in all UI assets

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* fix proxy when using with the API_prefix

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

---------

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* [FEATURE] Label metrics in stat chart (#2574)

* Label metrics

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* add regex to label metrics

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

---------

Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>

* [IGNORE] CI: e2e: bump actions/upload-artifact to v4 (#2564)

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* Merge pull request #2584 from perses/nexucis/release

Release v0.50.1

---------

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>
Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Co-authored-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com>
Co-authored-by: Belyakin Aleksandr Andreevich <belyakinaa@cloudx.group>
Co-authored-by: Célian GARCIA <celian.garcia@amadeus.com>
Co-authored-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables: autocomplete is broken when “All” is the currently selected value
2 participants
0