-
Notifications
You must be signed in to change notification settings - Fork 98
[BUGFIX] ListVariable: fix autocomplete when 'All' is selected #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5c491e
to
f453cba
Compare
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
f453cba
to
7ea06ad
Compare
AntoineThebaud
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you on that one 🚀
Nexucis
pushed a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Nexucis
added a commit
that referenced
this pull request
Jan 23, 2025
* [BUGFIX] ListVariable: fix autocomplete when 'All' is selected (#2554) Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com> * [IGNORE] Add error boundary around recent dashboard on home page (#2560) Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com> * [FEATURE] Value mapping settings for Status History and Stat Chart (#2462) * Status History Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * add value mapping to stat chart Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * add tests Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * update migration Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix cue format Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix types Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix mapping priority Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix zero value mapping Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * revert box styles Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * Update ui/components/src/StatChart/StatChart.tsx Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com> Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix threshold condition Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix test Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * update mui grid Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix lint Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * fix Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * add stat chart value mapping migration and test Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * update regex value mapping Signed-off-by: Alexander Belya 8000 kin <21216343+abelyakin@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com> Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * add support to greater then and less then to range Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> --------- Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> Co-authored-by: Belyakin Aleksandr Andreevich <belyakinaa@cloudx.group> Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com> * [BUGFIX] Login from percli (method not allowed) (#2577) * [BUGFIX] Login from percli (method not allowed) Signed-off-by: Célian Garcia <celian.garcia@amadeus.com> * move urlutils method to pkg/api/v1/common Signed-off-by: Augustin Husson <husson.augustin@gmail.com> --------- Signed-off-by: Célian Garcia <celian.garcia@amadeus.com> Signed-off-by: Augustin Husson <husson.augustin@gmail.com> Co-authored-by: Augustin Husson <husson.augustin@gmail.com> * [BUGFIX] Inject API prefix in all UI assets (#2576) * [BUGFIX] Inject API prefix in all UI assets Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix proxy when using with the API_prefix Signed-off-by: Augustin Husson <husson.augustin@gmail.com> --------- Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * [FEATURE] Label metrics in stat chart (#2574) * Label metrics Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * add regex to label metrics Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> --------- Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> * [IGNORE] CI: e2e: bump actions/upload-artifact to v4 (#2564) Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> * Merge pull request #2584 from perses/nexucis/release Release v0.50.1 --------- Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com> Signed-off-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> Signed-off-by: Célian Garcia <celian.garcia@amadeus.com> Signed-off-by: Augustin Husson <husson.augustin@gmail.com> Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com> Co-authored-by: Alexander Belyakin <21216343+abelyakin@users.noreply.github.com> Co-authored-by: Belyakin Aleksandr Andreevich <belyakinaa@cloudx.group> Co-authored-by: Célian GARCIA <celian.garcia@amadeus.com> Co-authored-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #2277. Found other issue when testing the fix: dropdown position changing when removing change from All to an item
Screenshots
Checklist
[<catalog_entry>] <commit message>
naming convention using one of thefollowing
catalog_entry
values:FEATURE
,ENHANCEMENT
,BUGFIX
,BREAKINGCHANGE
,DOC
,IGNORE
.UI Changes
See Storybook
and e2e docs for more details. Common issues
include: