8000 [BUGIFX] ListVariable: do not clear input value when selecting a value by Gladorme · Pull Request #2672 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGIFX] ListVariable: do not clear input value when selecting a value #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

[BUGIFX] ListVariable: do not clear input value when selecting a value #2672

merged 1 commit into from
Feb 24, 2025

Conversation

Gladorme
Copy link
Member
@Gladorme Gladorme commented Feb 24, 2025 •
edited
Loading

Description

Regression from #2554 😅
Closes #2669

Screenshots

output

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@Gladorme
[BUGIFX] ListVariable: do not clear input value when selecting a value
10188ee 
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
AntoineThebaud
AntoineThebaud approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor
@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'didn't now it worked before :D

🙏

@Nexucis
Copy link
Member
Nexucis commented Feb 24, 2025 •
edited
Loading

nice fix !

@Nexucis Nexucis added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit b89e1ce Feb 24, 2025
18 checks passed
@Nexucis Nexucis deleted the gladorme/fix-2669 branch February 24, 2025 15:40
jgbernalp pushed a commit that referenced this pull request Mar 13, 2025
@Gladorme @jgbernalp
[BUGIFX] ListVariable: do not clear input value when selecting a value (
979c417 
#2672)

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineThebaud AntoineThebaud AntoineThebaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable filter search reset when you click on value
3 participants
@Gladorme @Nexucis @AntoineThebaud
0