-
Notifications
You must be signed in to change notification settings - Fork 801
0.5.4 #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.5.4 #520
Conversation
- IMPORTANT: Change naming of position utilities to avoid conflicts
- Update dark color variable
- Fix sidebar hash link bug Fix Docs hash linking bug #482
- Fix browser support typo Typo on browsers element #469
- Fix code typo typo fix #460
- Fix GitHub button z-index bug docs: fix fixed problem with sidebar #458
- Fix Bar background color issue by adding !important to color utilities
- Fix chip bug when content is too long Chips with figure as avatar will not show the avatar if its content is long #506
- Fix multiple select height bug Moves the multiple select below to avoid overwriting the height #508
Tick icon prettier (checkbox, timeline)
fix animation on scale on chrome
…me. Hardcoded #fff and absent background colour make dark contrast themes unreadable
Fix animation of popover
Match form input/option element background colours to the overall the…
position: fixed !important; | ||
} | ||
|
||
.centered { | ||
.p-sticky { | ||
position: sticky !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
@@ -12,7 +12,7 @@ | |||
// Text color utility mixin | |||
@mixin text-color-variant($name: ".text-primary", $color: $primary-color) { | |||
#{$name} { | |||
color: $color; | |||
color: $color !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
@@ -1,7 +1,7 @@ | |||
// Background color utility mixin | |||
@mixin bg-color-variant($name: ".bg-primary", $color: $primary-color) { | |||
#{$name} { | |||
background: $color; | |||
background: $color !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
option { | ||
padding: $unit-h $unit-1; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
background: #fff url("data:image/svg+xml;charset=utf8,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%204%205'%3E%3Cpath%20fill='%23667189'%20d='M2%200L0%202h4zm0%205L0%203h4z'/%3E%3C/svg%3E") no-repeat right .35rem center/.4rem .5rem; | ||
padding-right: $control-icon-size + $control-padding-x; | ||
} | ||
background: $bg-color-light; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains trailing whitespace