8000 0.5.4 by picturepan2 · Pull Request #520 · picturepan2/spectre · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

0.5.4 #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 3, 2018
Merged

0.5.4 #520

merged 18 commits into from
Nov 3, 2018

Conversation

picturepan2
Copy link
Owner

@picturepan2 picturepan2 self-assigned this Nov 3, 2018
position: fixed !important;
}

.centered {
.p-sticky {
position: sticky !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

@@ -12,7 +12,7 @@
// Text color utility mixin
@mixin text-color-variant($name: ".text-primary", $color: $primary-color) {
#{$name} {
color: $color;
color: $color !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

@@ -1,7 +1,7 @@
// Background color utility mixin
@mixin bg-color-variant($name: ".bg-primary", $color: $primary-color) {
#{$name} {
background: $color;
background: $color !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

option {
padding: $unit-h $unit-1;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

background: #fff url("data:image/svg+xml;charset=utf8,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%204%205'%3E%3Cpath%20fill='%23667189'%20d='M2%200L0%202h4zm0%205L0%203h4z'/%3E%3C/svg%3E") no-repeat right .35rem center/.4rem .5rem;
padding-right: $control-icon-size + $control-padding-x;
}
background: $bg-color-light;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

@picturepan2 picturepan2 merged commit 0a6c764 into master Nov 3, 2018
@picturepan2 picturepan2 deleted the 0.5.4 branch November 3, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0