[Improvement] Only show area EditableDialogBox dialog when it actually has items to edit #11070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rberneder Should already be fixed. See #10962 Edit: I see it is fixed for areablock and not for area. Maybe we should use the same fix? |
…tems to edit (adopted implementation in Area to the one in AreaBlock )
|
@rberneder please rebase on 10.2 branch. thanks! |
…rue in `Document::getByPath()` (#11018) * Don't return Document from runtime cache when $force parameter is true in Document::getByPath() * Remove unused variable
Regex validation in dataobjects currently does not support UTF-8, making unicode regex validation impossible. Added u modifier to checkValidity method to resolve.
* Support link generator for mockup objects * Code update * Allow any object for link generator * Apply suggestions from code review Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de> * Revert typehint and add documentation for mockups * fix param declaration * Update models/DataObject/ClassDefinition/LinkGeneratorInterface.php Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de> * Update models/DataObject/ClassDefinition/LinkGeneratorInterface.php Co-authored-by: Jacob Dreesen <jacob@hdreesen.de> Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de> Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
* Remove Document from runtime path cache after it was deleted * Extract `getPathCacheKey()` method * Remove unused imports * Remove Document and its children from runtime path cache after it was saved with a new path * Fix clearing path cache on update The old path must be cleared, as this is the one that may already be cached.
…mbnails are configured (#11046)
add u modifier to javascript input.js regex checks relates to https://github.com/pimcore/pimcore/pull/11033/commits
* Do not initialize db schema in constructor. * Do not initialize db schema in constructor. * Always remove schema. * Always return schema. * Fix phpstan test (#1) * Fix phpstan * Add ConnectionInterface::getSchemaManager() * Remove unused use * Code improvements. * Revert changes regarding connection interface. * Add method annotation to simplify code in getSchema() Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
…o "setTime() on bool" error (#11050) * [BUG] Pricing Rules - Saving pricing rule with date range condition leads to "setTime() on bool" error * [BUG] Pricing Rules - Saving pricing rule with date range condition leads to "setTime() on bool" error
* fix #11059 * Update models/DataObject/ClassDefinition/Data/Table.php Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com> Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
|
@rberneder Now we have unrelated commits in the PR. Could you please create a new PR with relevant changes? thanks! |
|
Fixed directly on 10.2 branch 82dae69 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
An area is used multiple times throughout different templates.
Problem
The area shall offer an EditableDialogBox in the one template, but must not have such in the other one.
Solution
The area checks if there are items to be edited. If so, the dialog is output.