8000 .*: update change-log for v2.0.5 (#1934) by ti-chi-bot · Pull Request #1936 · pingcap/dm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

.*: update change-log for v2.0.5 (#1934) #1936

Merged
merged 5 commits into from
Jul 30, 2021
Merged

.*: update change-log for v2.0.5 (#1934) #1936

merged 5 commits into from
Jul 30, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1934

What problem does this PR solve?

update change-log for v2.0.5

@ti-chi-bot
Copy link
Member Author
ti-chi-bot commented Jul 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added require-LGT1 for small PR, LGT1 is enough size/M status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels Jul 29, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2021
Merged
@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lance6716 July 29, 2021 11:40
@GMHDBJD GMHDBJD force-pushed the cherry-pick-1934-to-release-2.0 branch from b67fe70 to 68f08ed Compare July 29, 2021 11:48
@GMHDBJD
Copy link
Collaborator
GMHDBJD commented Jul 29, 2021 •
edited
Loading

Manually cherrypick #1934 and #1794 and #1937

@Ehco1996
Copy link
Contributor

metrcs test still not stable

log is

[2021-07-29T12:26:33.758Z] [2021/07/29 20:26:21.936 +08:00] [DEBUG] [syncer.go:1347] ["ticker Reset"] [task=test] [unit="binlog replication"] [workerLagKey=lag_0] [tickerInterval=5s] ["current ts"=1627561581]
[2021-07-29T12:26:33.758Z] [2021/07/29 20:26:21.936 +08:00] [DEBUG] [syncer.go:1388] ["no job in queue, update lag to zero"] [task=test] [unit="binlog replication"] [workerLagKey=lag_0] ["current ts"=1627561581]

it is so wired that ticker reset at ts=1627561581 but at same time it still go into no job in queue logic 🤔
i don't konw why

any suggestions? @GMHDBJD @lance6716

@GMHDBJD
Copy link
Collaborator
GMHDBJD commented Jul 30, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jul 30, 2021
@GMHDBJD
Copy link
Collaborator
GMHDBJD commented Jul 30, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 85a3d3b

@GMHDBJD
Copy link
Collaborator
GMHDBJD commented Jul 30, 2021

/hold

@GMHDBJD
Copy link
Collaborator
GMHDBJD commented Jul 30, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 92baadb into pingcap:release-2.0 Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees

@GMHDBJD GMHDBJD

Labels
require-LGT1 for small PR, LGT1 is enough size/M status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @GMHDBJD @Ehco1996 @lance6716
0