8000 changelog: update description by GMHDBJD · Pull Request #1937 · pingcap/dm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

changelog: update description #1937

Merged
merged 4 commits into from
Jul 30, 2021
Merged

changelog: update description #1937

merged 4 commits into from
Jul 30, 2021

Conversation

GMHDBJD
Copy link
Collaborator
@GMHDBJD GMHDBJD commented Jul 29, 2021

What problem does this PR solve?

update pr description

@ti-chi-bot
Copy link
Member
ti-chi-bot commented Jul 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling 8000 /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from Ehco1996 July 29, 2021 12:08
@GMHDBJD GMHDBJD added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Jul 29, 2021
@GMHDBJD GMHDBJD mentioned this pull request Jul 29, 2021
Merged
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jul 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 30, 2021
@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 42dca85

@lance6716
Copy link
Collaborator

/hold

@lance6716
Copy link
Collaborator

/unhold

@GMHDBJD
Copy link
Collaborator Author
GMHDBJD commented Jul 30, 2021

/run-all-tests

1 similar comment
@GMHDBJD
Copy link
Collaborator Author
GMHDBJD commented Jul 30, 2021

/run-all-tests

@lance6716
Copy link
Collaborator

/run-all-tests metrics fail

@Ehco1996
Copy link
Contributor
Ehco1996 commented Jul 30, 2021 •
edited
Loading

/run-all-tests metrics fail

@GMHDBJD @lance6716 perhaps we can remove metrics test for now ?
i will fix it in another PR

@ti-chi-bot
Copy link
Member

@GMHDBJD: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Collaborator

/run-all-tests DM-master didn't up timely

@ti-chi-bot ti-chi-bot merged commit c1f0d07 into master Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
size/XS status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @ti-chi-bot @Ehco1996 @lance6716
0