feat: modify zclclusterview popup to page #1383
Conversation
e4efd9c to
8ddbf26
Compare
| @@ -21,16 +21,16 @@ describe('Testing disabling enabled attributes', () => { | |||
| { retries: { runMode: 2, openMode: 2 } }, | |||
| () => { | |||
| cy.get( | |||
| '.table_body:first > :nth-child(2) > .q-mt-xs > .q-toggle__inner' | |||
| '.attribute_table_body:first > :nth-child(2) > .q-mt-xs > .q-toggle__inner ' | |||
There was a problem hiding this comment.
Get rid of the space .q-toggle__inner ' at the end before the single quote
| @@ -114,31 +114,35 @@ | |||
| </div> | |||
| </q-btn> | |||
| </router-link> | |||
| <router-link v-slot="{ isActive, navigate }" to="/notifications"> | |||
There was a problem hiding this comment.
Did you just remove router-link here?
There was a problem hiding this comment.
yes, and i added a click function to btn, similar to preview btn
| @@ -198,12 +207,7 @@ export default { | |||
| this.tab = val | |||
| }, | |||
| }, | |||
| mounted() { | |||
There was a problem hiding this comment.
because now we dont need to set table's height manually.
| @@ -222,20 +226,10 @@ export default { | |||
| setIndividualClusterFilterString(filterString) { | |||
| this.$store.dispatch('zap/setIndividualClusterFilterString', filterString) | |||
| }, | |||
| onResize(size) { | |||
There was a problem hiding this comment.
it is not needed anymore. It was necessary for the table's height in popup.
| }, | ||
| data() { | ||
| return { | ||
| tab: 'attributes', | ||
| tableHeight: '30px', |
There was a problem hiding this comment.
similar to the previous comment
| @@ -58,7 +58,7 @@ limitations under the License. | |||
| class="col v-step-2" | |||
| use-input | |||
| 10000 | :multiple="enableMultipleDevice" | ||
| :use-chips="enableMultipleDevice" | |||
| use-chips | |||
There was a problem hiding this comment.
in standalone zigbee mode, we could not use the backspace / remove btn on the new card endpoint card. But if we modify this, it is working well. (I had a meeting with @paulr34, @dhchandw, @ethanzhouyc and this was one of the topics.)
There was a problem hiding this comment.
Does this affect the multiple device type selection behavior in any way?
src/layouts/ZclLayout.vue
Outdated
There was a problem hiding this comment.
Were the 3 .vue files that are deleted not used at all?
There was a problem hiding this comment.
we are not using there anymore
| expect(wrapper.html().length).toBeGreaterThan(90) | ||
| }, | ||
| timeout.short() | ||
| ) |
There was a problem hiding this comment.
Why are these 2 tests removed?
There was a problem hiding this comment.
Because these 2 files are not exist anymore.
As you know i cleaned up the code.
d7c1f3c to
88bb0ef
Compare
No description provided.