-
Notifications
You must be signed in to change notification settings - Fork 88
feat: modify zclclusterview popup to page #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tbrkollar
merged 11 commits into
project-chip:master
from
tbrkollar:feature/notification-panel
Aug 9, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bacd352
feat: modify zclclusterview popup to page
tbrkollar 382d8e7
refactor: delete unused old layouts
tbrkollar b6656a3
feat: add notification panel to right side
tbrkollar 0b35030
fix: fix page size and test
tbrkollar abca163
fix: move id to above in zclclusterView
tbrkollar f566e52
test: add cypress test for notification panel functionality.
tbrkollar 9afe38f
fix: add color to matter mode
tbrkollar 183e52a
feat: add chip style to selection on new endpoint card
tbrkollar cb75dc5
fix: add padding to logo when the right panel is opened
tbrkollar 0726adb
feat: add word-wrap to cells on notification panel
tbrkollar 88bb0ef
fix: remove unnecessary space from test
8000
tbrkollar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /// <reference types="cypress" /> | ||
|
|
||
| Cypress.on('uncaught:exception', (err, runnable) => { | ||
| // returning false here prevents Cypress from | ||
| // failing the test | ||
| return false | ||
| }) | ||
|
|
||
| describe('Check notification panel functionality', () => { | ||
| it('Set Data', () => { | ||
| cy.fixture('baseurl').then((data) => { | ||
| cy.visit(data.baseurl) | ||
| }) | ||
| cy.setZclProperties() | ||
| }) | ||
| it( | ||
| 'Open notification panel', | ||
| { retries: { runMode: 2, openMode: 2 } }, | ||
| () => { | ||
| cy.get('#Notifications').click() | ||
| cy.wait(500) | ||
| cy.get('#NotificationPanel') | ||
| .parent() | ||
| .should('not.have.class', ' q-layout--prevent-focus') | ||
| } | ||
| ) | ||
| it('Check active status on navbar', () => { | ||
| cy.get('#Notifications').should('have.class', 'navmenu-item--active') | ||
| }) | ||
| it( | ||
| 'Close notification panel', | ||
| { retries: { runMode: 2, openMode: 2 } }, | ||
| () => { | ||
| cy.get('#Notifications').click() | ||
| cy.wait(500) | ||
| cy.get('#NotificationPanel') | ||
| .parent() | ||
| .should('have.class', 'q-layout--prevent-focus') | ||
| } | ||
| ) | ||
| it( | ||
| 'Open notification panel and open preview panel', | ||
| { retries: { runMode: 2, openMode: 2 } }, | ||
| () => { | ||
| cy.get('#Notifications').click() | ||
| cy.wait(500) | ||
| cy.get('#NotificationPanel') | ||
| .parent() | ||
| .should('not.have.class', 'q-layout--prevent-focus') | ||
| cy.get('#Preview').click() | ||
| cy.get('#NotificationPanel') | ||
| .parent() | ||
| .should('have.class', 'q-layout--prevent-focus') | ||
| } | ||
| ) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you just remove router-link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, and i added a click function to btn, similar to preview btn