Switch clusters/shared/EnumCheck.h to jinja #38843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38843: Size comparison from 1f6aada to 6061f5e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
May 9, 2025
|
PR #38843: Size comparison from 1f6aada to 8eb5c9d Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
scripts/py_matter_idl/matter/idl/generators/cpp/sdk/sdk_generator.py
Outdated
Show resolved
Hide resolved
bzbarsky-apple
reviewed
8000
May 9, 2025
scripts/py_matter_idl/matter/idl/generators/cpp/sdk/sdk_generator.py
Outdated
Show resolved
Hide resolved
|
PR #38843: Size comparison from f4d171a to de6d919 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Open for a month, it does not seem there is much desire to do the switch and we have a workaround. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces the ordering to be deterministic. this fixes #38844 by switching generation of
zzz_generated/app-common/clusters/shared/EnumsCheck.hfrom zapt (deleted) to jinja (newly created).It turns out that matter constants for enums do "preseve acronyms" so had to add extra logic to undo that for C++ compatibility.
Testing
This refactored code generation: given that
zzz_generated/app-common/clusters/shared/EnumsCheck.hcontent is identical except header comments, this shows that the conversion does not alter functionality and is a pure migration without sideffects.